linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: "Håkon Løvdal" <hlovdal@gmail.com>
Cc: linux-ide@vger.kernel.org, jgarzik@pobox.com, tj@kernel.org
Subject: Re: [PATCH]ata:ahci.c Fix warning: comparison between 'enum 	<anonymous>' and 'enum <anonymous>'
Date: Tue, 29 Jun 2010 23:25:16 -0700	[thread overview]
Message-ID: <4C2AE34C.4020103@gmail.com> (raw)
In-Reply-To: <AANLkTinetp4EnDl_O89pvccbJnuzRRQc5FHDX3-P3-Jv@mail.gmail.com>

On 06/29/2010 11:11 PM, Håkon Løvdal wrote:
> On 30 June 2010 04:53, Justin P. Mattock<justinmattock@gmail.com>  wrote:
>> -       int n_ports, i, rc;
>> +       int n_ports, i, rc, sum = 32;
>>
>>         VPRINTK("ENTER\n");
>>
>> -       WARN_ON(ATA_MAX_QUEUE>  AHCI_MAX_CMDS);
>> +       WARN_ON(ATA_MAX_QUEUE>  sum);
>
> Should'nt that rather be
>
>         int n_ports, i, rc, sum = AHCI_MAX_CMDS;
>
> ?
>
> BR Håkon Løvdal
>

I didnt even think todo that. I just rebuilt with that change, and all 
is good from the compiling stand point. should I resend?

Thanks for the help.

Justin P. Mattock

  reply	other threads:[~2010-06-30  6:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-30  2:53 [PATCH]ata:ahci.c Fix warning: comparison between 'enum <anonymous>' and 'enum <anonymous>' Justin P. Mattock
2010-06-30  6:11 ` Håkon Løvdal
2010-06-30  6:25   ` Justin P. Mattock [this message]
2010-06-30  6:38   ` Justin P. Mattock
  -- strict thread matches above, loose matches on Subject: below --
2010-07-03 14:29 Justin P. Mattock
2010-07-03 14:30 ` Tejun Heo
2010-07-14  7:51 ` Jeff Garzik
2010-07-14 13:35   ` Justin P. Mattock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C2AE34C.4020103@gmail.com \
    --to=justinmattock@gmail.com \
    --cc=hlovdal@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).