From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Justin P. Mattock" Subject: Re: [PATCH]ata:ahci.c Fix warning: comparison between 'enum ' and 'enum ' Date: Tue, 29 Jun 2010 23:25:16 -0700 Message-ID: <4C2AE34C.4020103@gmail.com> References: <1277866406-8253-1-git-send-email-justinmattock@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:37755 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065Ab0F3GYz (ORCPT ); Wed, 30 Jun 2010 02:24:55 -0400 Received: by pzk7 with SMTP id 7so71001pzk.19 for ; Tue, 29 Jun 2010 23:24:54 -0700 (PDT) In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: =?UTF-8?B?SMOla29uIEzDuHZkYWw=?= Cc: linux-ide@vger.kernel.org, jgarzik@pobox.com, tj@kernel.org On 06/29/2010 11:11 PM, H=C3=A5kon L=C3=B8vdal wrote: > On 30 June 2010 04:53, Justin P. Mattock wr= ote: >> - int n_ports, i, rc; >> + int n_ports, i, rc, sum =3D 32; >> >> VPRINTK("ENTER\n"); >> >> - WARN_ON(ATA_MAX_QUEUE> AHCI_MAX_CMDS); >> + WARN_ON(ATA_MAX_QUEUE> sum); > > Should'nt that rather be > > int n_ports, i, rc, sum =3D AHCI_MAX_CMDS; > > ? > > BR H=C3=A5kon L=C3=B8vdal > I didnt even think todo that. I just rebuilt with that change, and all=20 is good from the compiling stand point. should I resend? Thanks for the help. Justin P. Mattock