From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Justin P. Mattock" Subject: Re: [PATCH v2]ata:ahci.c Fix warning: comparison between 'enum ' and 'enum ' Date: Wed, 30 Jun 2010 00:21:44 -0700 Message-ID: <4C2AF088.2080609@gmail.com> References: <1277879827-18233-1-git-send-email-justinmattock@gmail.com> <4C2AE8FE.3020409@kernel.org> <4C2AED03.7070103@gmail.com> <4C2AEE2A.8060405@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-px0-f174.google.com ([209.85.212.174]:45822 "EHLO mail-px0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387Ab0F3HVY (ORCPT ); Wed, 30 Jun 2010 03:21:24 -0400 Received: by pxi8 with SMTP id 8so236574pxi.19 for ; Wed, 30 Jun 2010 00:21:24 -0700 (PDT) In-Reply-To: <4C2AEE2A.8060405@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: linux-ide@vger.kernel.org, jgarzik@pobox.com On 06/30/2010 12:11 AM, Tejun Heo wrote: > On 06/30/2010 09:06 AM, Justin P. Mattock wrote: >>> Hmm, is this something we wanna go around the kernel and updating >>> sources? Or should we just flick a gcc option? >> >> the flick a gcc option seems easier todo, but my guess its probably not >> the right way of dealing with the issue(even a warning). > > What does the extra warning buy us? There are several places which > use anonymous enums for constants and I can't see what the benefit of > this warning would be. > I don't think it buys us anything..think it's just saying "hey you have two #defines with the same value" or something in that area(if Im reading the warning correctly) funny thing is, is gcc should of done the same with the original patch that I sent, as well as the second.. (but could be wrong). >>> And, just do WARN_ON((int)ATA_MAX_QUEUE> (int)AHCI_MAX_CMDS) >> >> that builds clean. keep in mind I just compile tested, no rebooting or >> anything. Should I just resend with what you posted, and call it that, >> or is this something that needs more? > > I think it would be better to first decide what to do about the > new warnings. > > Thanks. > sure.. no problem. cheers, Justin P. Mattock