From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, tj@kernel.org
Subject: Re: [PATCH]ata:ahci.c Fix warning: comparison between 'enum <anonymous>' and 'enum <anonymous>'
Date: Wed, 14 Jul 2010 06:35:00 -0700 [thread overview]
Message-ID: <4C3DBD04.7020908@gmail.com> (raw)
In-Reply-To: <4C3D6C9D.7070708@pobox.com>
On 07/14/2010 12:51 AM, Jeff Garzik wrote:
> On 07/03/2010 10:29 AM, Justin P. Mattock wrote:
>> The below patch casts ATA_MAX_QUEUE to int because GCC will
>> give a warning message about the two different enum blocks:
>> CC drivers/ata/ahci.o
>> drivers/ata/ahci.c: In function 'ahci_init_one':
>> drivers/ata/ahci.c:1045:2: warning: comparison between
>> 'enum<anonymous>' and 'enum<anonymous>'
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>
>> ---
>> drivers/ata/ahci.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
>> index f252253..fe75d8b 100644
>> --- a/drivers/ata/ahci.c
>> +++ b/drivers/ata/ahci.c
>> @@ -1042,7 +1042,7 @@ static int ahci_init_one(struct pci_dev *pdev,
>> const struct pci_device_id *ent)
>>
>> VPRINTK("ENTER\n");
>>
>> - WARN_ON(ATA_MAX_QUEUE> AHCI_MAX_CMDS);
>> + WARN_ON((int)ATA_MAX_QUEUE> AHCI_MAX_CMDS);
>>
>
> applied
>
>
>
o.k. cool..
Justin P. Mattock
next prev parent reply other threads:[~2010-07-14 13:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 14:29 [PATCH]ata:ahci.c Fix warning: comparison between 'enum <anonymous>' and 'enum <anonymous>' Justin P. Mattock
2010-07-03 14:30 ` Tejun Heo
2010-07-14 7:51 ` Jeff Garzik
2010-07-14 13:35 ` Justin P. Mattock [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-30 2:53 Justin P. Mattock
2010-06-30 6:11 ` Håkon Løvdal
2010-06-30 6:25 ` Justin P. Mattock
2010-06-30 6:38 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3DBD04.7020908@gmail.com \
--to=justinmattock@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).