From: Tejun Heo <htejun@gmail.com>
To: hs@denx.de
Cc: Robert Hancock <hancockrwd@gmail.com>,
Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org
Subject: Re: ata, pcmcia: problem with irq and ata_dev_read_id()
Date: Mon, 26 Jul 2010 15:11:16 +0200 [thread overview]
Message-ID: <4C4D8974.3030400@gmail.com> (raw)
In-Reply-To: <4C4D86A4.2040500@denx.de>
Hello,
On 07/26/2010 02:59 PM, Heiko Schocher wrote:
> Hmm.. I am not sure if "leaving things as it is" is the better way,
> because this behaviour comes every time, I insert a card! And with
> my patch I can prevent this behaviour ...
Yes, it fixes the behavior which comes every time in your
configuration but it might at the same time break other configurations
which are more common. ATA probing is a painful thing and we had
pretty good reasons to turn on TFLAG_POLLING for IDENTIFY by default.
The only side effect your configuration is going to have is IRQ
polling kicking in for short period of time after device insertion.
Please also note that the device can't be quirked as it's before its
identity is known. So, yeah, I think it is better to leave things as
is as long as IRQ flakiness can be handled in acceptable manner which
we need to do anyway.
Thanks.
--
tejun
prev parent reply other threads:[~2010-07-26 13:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 5:57 ata, pcmcia: problem with irq and ata_dev_read_id() Heiko Schocher
2010-05-31 23:55 ` Robert Hancock
2010-06-28 5:31 ` Heiko Schocher
2010-07-02 15:01 ` Tejun Heo
2010-07-05 8:26 ` Heiko Schocher
2010-07-05 8:52 ` Tejun Heo
2010-07-05 9:25 ` Heiko Schocher
2010-07-05 9:33 ` Tejun Heo
2010-07-26 12:59 ` Heiko Schocher
2010-07-26 13:11 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4D8974.3030400@gmail.com \
--to=htejun@gmail.com \
--cc=hancockrwd@gmail.com \
--cc=hs@denx.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).