From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH #upstream-fixes] ata_piix: fix locking around SIDPR access Date: Sun, 01 Aug 2010 19:48:36 -0400 Message-ID: <4C5607D4.20302@garzik.org> References: <4C45B091.2000002@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-gx0-f174.google.com ([209.85.161.174]:57322 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968Ab0HAXsj (ORCPT ); Sun, 1 Aug 2010 19:48:39 -0400 Received: by gxk23 with SMTP id 23so1099738gxk.19 for ; Sun, 01 Aug 2010 16:48:39 -0700 (PDT) In-Reply-To: <4C45B091.2000002@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: "linux-ide@vger.kernel.org" , stable , Mark Knecht , Paul Check On 07/20/2010 10:20 AM, Tejun Heo wrote: > SIDPR window registers are shared across ports and as each access is > done in two steps, accesses to different ports under EH may race. > This primarily is caused by incorrect host locking in EH context and > should be fixed by defining locking requirements for each EH operation > which can be used during EH and enforcing them but for now work around > the problem by adding a dedicated SIDPR lock and grabbing it for each > SIDPR access. > > Signed-off-by: Tejun Heo > Reported-by: Mark Knecht > Reported-by: Paul Check > Cc: stable@kernel.org > --- > drivers/ata/ata_piix.c | 8 ++++++++ > 1 file changed, 8 insertions(+) applied