From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] SATA / AHCI: Do not play with the link PM during suspend to RAM Date: Tue, 17 Aug 2010 14:09:33 +0200 Message-ID: <4C6A7BFD.1070604@gmail.com> References: <201007091750.05020.stephan.diestelhorst@amd.com> <201008171319.25080.rjw@sisk.pl> <4C6A7281.3030804@gmail.com> <201008171410.21382.stephan.diestelhorst@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:48936 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751379Ab0HQMMo (ORCPT ); Tue, 17 Aug 2010 08:12:44 -0400 In-Reply-To: <201008171410.21382.stephan.diestelhorst@amd.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Stephan Diestelhorst Cc: "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "linux-ide@vger.kernel.org" , "linux-pm@lists.osdl.org" , Stephan Diestelhorst Hello, On 08/17/2010 02:10 PM, Stephan Diestelhorst wrote: > If you want me to test anything... let me know. Since I do not know > much about the ATA code, I do not know what to change where. (A simple > grep for sd_suspend in drivers/ata didn't turn up anything.) Oh, sure, the following should be enough. Thanks. diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 8802e48..892ccc7 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2456,6 +2456,8 @@ static int sd_suspend(struct device *dev, pm_message_t mesg) struct scsi_disk *sdkp = scsi_disk_get_from_dev(dev); int ret = 0; + return 0; + if (!sdkp) return 0; /* this can happen */ -- tejun