Re: [PATCH #upstream-fixes] pata_cmd64x: revert commit d62f5576

[Tejun Heo <tj@kernel.org>]

Hello,

On 08/17/2010 02:56 PM, Bartlomiej Zolnierkiewicz wrote:
> On Tuesday 17 August 2010 02:13:42 pm Tejun Heo wrote:
>> Commit d62f5576 (pata_cmd64x: fix handling of address setup timings)
>> incorrectly called ata_timing_compute() on UDMA mode on 0 @UT leading
>> to devide by zero fault.  Revert it until better fix is available.
>> This is reported in bko#16607 by Milan Kocian who also root caused it.
>>
>>   https://bugzilla.kernel.org/show_bug.cgi?id=16607
> 
> How's about giving the ATA maintainer some time to resolve the issue
> properly?

Yeap, sure.

> The revert should be a last resort action (+ the issue was reported
> only yesterday) as it introduces another regression (it just replaces
> new bug with the old bug while adding noise in the process)..

The old problem is much less severe tho.  The introduced regression
causes oops while the old bug probably doesn't show itself too often.
Does it really need to merge the DMA timings too?  If the device can't
do certain timing, it's PIO configuration should reflect that so
merging PIO part only should be enough for PIO configuration, no?

Thanks.

-- 
tejun