From: Tejun Heo <tj@kernel.org>
To: Grant Grundler <grundler@google.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
"Wilcox, Matthew R" <matthew.r.wilcox@intel.com>,
Linux IDE <linux-ide@vger.kernel.org>,
Gwendal Grignou <gwendal@google.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.6.35 libata support for > 512 byte sectors (e.g. 4K Native)
Date: Tue, 17 Aug 2010 17:22:11 +0200 [thread overview]
Message-ID: <4C6AA923.4040302@kernel.org> (raw)
In-Reply-To: <AANLkTi=R4GQGVE5AvU9hdWXdtqZzaOswrGQA+cPgO58W@mail.gmail.com>
Hello,
On 08/16/2010 10:24 PM, Grant Grundler wrote:
> I suspect legacy tools might be needed to update firmware and those
> might continue to function if DRQ block size is still 512 byte. I'd
> like to leave this hardcoded to ATA_SECT_SIZE until someone can
> demonstrate a need to change it. Ok?
I agree it'll be best to leave it 512bytes. We'll just cause more
confusion by overriding the sector size there. Another possible
approach would be simply failing the ioctl if logical sector size
isn't 512 byte. The ioctl should probably be deprecated one day
anyway.
Thanks.
--
tejun
prev parent reply other threads:[~2010-08-17 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-15 0:00 [PATCH] 2.6.35 libata support for > 512 byte sectors (e.g. 4K Native) Grant Grundler
2010-08-15 4:37 ` Wilcox, Matthew R
2010-08-16 19:17 ` Grant Grundler
2010-08-16 19:41 ` Jeff Garzik
2010-08-16 20:24 ` Grant Grundler
2010-08-17 15:22 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6AA923.4040302@kernel.org \
--to=tj@kernel.org \
--cc=grundler@google.com \
--cc=gwendal@google.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.r.wilcox@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).