From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH #upstream-fixes] pata_cmd64x: revert commit d62f5576 Date: Tue, 17 Aug 2010 17:30:07 -0400 Message-ID: <4C6AFF5F.50403@garzik.org> References: <4C6A7CF6.5090706@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:38714 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789Ab0HQVaM (ORCPT ); Tue, 17 Aug 2010 17:30:12 -0400 Received: by vws3 with SMTP id 3so5019478vws.19 for ; Tue, 17 Aug 2010 14:30:11 -0700 (PDT) In-Reply-To: <4C6A7CF6.5090706@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: "\"linux-ide@vger.kernel.org\" st" , stable , Bartlomiej Zolnierkiewicz , Alan Cox , Milan Kocian On 08/17/2010 08:13 AM, Tejun Heo wrote: > Commit d62f5576 (pata_cmd64x: fix handling of address setup timings) > incorrectly called ata_timing_compute() on UDMA mode on 0 @UT leading > to devide by zero fault. Revert it until better fix is available. > This is reported in bko#16607 by Milan Kocian who also root caused it. > > https://bugzilla.kernel.org/show_bug.cgi?id=16607 > > Signed-off-by: Tejun Heo > Reported-and-root-caused-by: Milan Kocian > Cc: Bartlomiej Zolnierkiewicz > Cc: stable@kernel.org > --- > drivers/ata/pata_cmd64x.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/ata/pata_cmd64x.c b/drivers/ata/pata_cmd64x.c > index 9f5da1c..905ff76 100644 > --- a/drivers/ata/pata_cmd64x.c > +++ b/drivers/ata/pata_cmd64x.c > @@ -121,14 +121,8 @@ static void cmd64x_set_timing(struct ata_port *ap, struct ata_device *adev, u8 m > > if (pair) { > struct ata_timing tp; > - > ata_timing_compute(pair, pair->pio_mode,&tp, T, 0); > ata_timing_merge(&t,&tp,&t, ATA_TIMING_SETUP); > - if (pair->dma_mode) { > - ata_timing_compute(pair, pair->dma_mode, > - &tp, T, 0); > - ata_timing_merge(&tp,&t,&t, ATA_TIMING_SETUP); applied; even if not perfect, this gets us into a better state.