Re: [PATCH #upstream] ahci: add HFLAG_YES_FBS and apply it to 88SE9128

[Jeff Garzik <jeff@garzik.org>]

On 07/24/2010 10:53 AM, Tejun Heo wrote:
> 88SE9128 can do FBS and sets it in HOST_CAP but forgets to set FBSCP
> in PORT_CMD.  Implement AHCI_HFLAG_YES_FBS and apply it to 88SE9128.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> --
>   drivers/ata/ahci.c    |   11 +++++++++++
>   drivers/ata/ahci.h    |    1 +
>   drivers/ata/libahci.c |   16 ++++++++++++++--
>   3 files changed, 26 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index f252253..41fa0a3 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -60,6 +60,7 @@ enum board_ids {
>   	board_ahci,
>   	board_ahci_ign_iferr,
>   	board_ahci_nosntf,
> +	board_ahci_yes_fbs,
>
>   	/* board IDs for specific chipsets in alphabetical order */
>   	board_ahci_mcp65,
> @@ -132,6 +133,14 @@ static const struct ata_port_info ahci_port_info[] = {
>   		.udma_mask	= ATA_UDMA6,
>   		.port_ops	=&ahci_ops,
>   	},
> +	[board_ahci_yes_fbs] =
> +	{
> +		AHCI_HFLAGS	(AHCI_HFLAG_YES_FBS),
> +		.flags		= AHCI_FLAG_COMMON,
> +		.pio_mask	= ATA_PIO4,
> +		.udma_mask	= ATA_UDMA6,
> +		.port_ops	=&ahci_ops,
> +	},
>   	/* by chipsets */
>   	[board_ahci_mcp65] =
>   	{
> @@ -362,6 +371,8 @@ static const struct pci_device_id ahci_pci_tbl[] = {
>   	/* Marvell */
>   	{ PCI_VDEVICE(MARVELL, 0x6145), board_ahci_mv },	/* 6145 */
>   	{ PCI_VDEVICE(MARVELL, 0x6121), board_ahci_mv },	/* 6121 */
> +	{ PCI_DEVICE(0x1b4b, 0x9123),
> +	  .driver_data = board_ahci_yes_fbs },			/* 88se9128 */
>
>   	/* Promise */
>   	{ PCI_VDEVICE(PROMISE, 0x3f20), board_ahci },	/* PDC42819 */
> diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
> index 7113c57..474427b 100644
> --- a/drivers/ata/ahci.h
> +++ b/drivers/ata/ahci.h
> @@ -209,6 +209,7 @@ enum {
>   							link offline */
>   	AHCI_HFLAG_NO_SNTF		= (1<<  12), /* no sntf */
>   	AHCI_HFLAG_NO_FPDMA_AA		= (1<<  13), /* no FPDMA AA */
> +	AHCI_HFLAG_YES_FBS		= (1<<  14), /* force FBS cap on */
>
>   	/* ap->flags bits */

applied