From: Tejun Heo <htejun@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Stephan Diestelhorst <stephan.diestelhorst@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-pm@lists.osdl.org" <linux-pm@lists.osdl.org>,
Stephan Diestelhorst <stephan.diestelhorst@gmail.com>
Subject: Re: [PATCH] libata: skip EH autopsy and recovery during suspend
Date: Thu, 02 Sep 2010 22:25:13 +0200 [thread overview]
Message-ID: <4C800829.9040802@gmail.com> (raw)
In-Reply-To: <201009022216.45303.rjw@sisk.pl>
Hello,
On 09/02/2010 10:16 PM, Rafael J. Wysocki wrote:
> Putting the issue at hand aside, I'm not really sure if using SCSI EH for
> suspending the controller is a good idea. It seems overly complicated and
> it doesn't match the new PCI suspend model with separate ->suspend(),
> ->freeze() and ->poweroff() callbacks. Moreover, the passing of pm_message_t
> back and forth doesn't make things clear either.
>
> Would it be possible to rework this thing entirely at one point?
Well, I think I would need more than that to rework the whole thing.
There are a lot of benefits in sharing the same path between probing /
error handling and suspend/resuming. ATA has a lot of quirks which
have to be dealt with and it will be very fragile to scatter handling
logics over multiple separate paths. We definitely can try to make
the plumbing from power management easier to follow.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-09-02 20:25 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 15:50 HDD not suspending properly / dead on resume Stephan Diestelhorst
2010-07-09 21:47 ` Stephan Diestelhorst
2010-07-09 21:53 ` Rafael J. Wysocki
2010-07-09 23:04 ` Stephan Diestelhorst
2010-07-10 0:06 ` Rafael J. Wysocki
2010-07-10 6:50 ` Stephan Diestelhorst
2010-07-10 10:03 ` Tejun Heo
2010-07-10 13:45 ` Rafael J. Wysocki
2010-07-28 21:50 ` [PATCH] SATA / AHCI: Do not play with the link PM during suspend to RAM (was: Re: HDD not suspending properly / dead on resume) Rafael J. Wysocki
2010-07-30 14:18 ` [PATCH] SATA / AHCI: Do not play with the link PM during suspend to RAM Tejun Heo
2010-08-05 16:08 ` Tejun Heo
2010-08-05 19:58 ` Rafael J. Wysocki
2010-08-06 6:30 ` Stephan Diestelhorst
2010-08-06 7:06 ` Tejun Heo
2010-08-06 9:04 ` Stephan Diestelhorst
2010-08-17 7:51 ` Stephan Diestelhorst
2010-08-17 8:08 ` Tejun Heo
2010-08-17 9:32 ` Stephan Diestelhorst
2010-08-17 10:15 ` Tejun Heo
2010-08-17 10:29 ` Stephan Diestelhorst
2010-08-17 10:51 ` Stephan Diestelhorst
2010-08-17 15:04 ` Tejun Heo
2010-08-17 21:28 ` Stephan Diestelhorst
2010-08-18 6:12 ` Tejun Heo
2010-08-19 16:23 ` Stephan Diestelhorst
2010-08-23 12:03 ` Tejun Heo
2010-08-23 18:58 ` Rafael J. Wysocki
2010-08-24 7:37 ` Tejun Heo
2010-08-24 20:39 ` Rafael J. Wysocki
2010-08-26 23:09 ` Rafael J. Wysocki
2010-08-26 23:46 ` Rafael J. Wysocki
2010-09-02 9:06 ` Tejun Heo
2010-09-02 10:02 ` [PATCH] libata: skip EH autopsy and recovery during suspend Tejun Heo
2010-09-02 14:33 ` Stephan Diestelhorst
2010-09-02 20:11 ` Rafael J. Wysocki
2010-09-02 20:52 ` Stephan Diestelhorst
2010-09-07 11:54 ` Stephan Diestelhorst
2010-09-02 20:16 ` Rafael J. Wysocki
2010-09-02 20:25 ` Tejun Heo [this message]
2010-09-02 20:28 ` Rafael J. Wysocki
2010-09-02 20:33 ` Tejun Heo
2010-09-02 21:01 ` [linux-pm] " Alan Stern
2010-09-02 21:09 ` Rafael J. Wysocki
2010-09-03 8:55 ` [linux-pm] " Tejun Heo
2010-09-03 14:16 ` Alan Stern
2010-09-07 12:05 ` [PATCH #upstream-fixes] " Tejun Heo
2010-08-24 16:07 ` [PATCH] SATA / AHCI: Do not play with the link PM during suspend to RAM Stephan Diestelhorst
2010-08-24 16:11 ` Stephan Diestelhorst
2010-08-26 16:15 ` Stephan Diestelhorst
2010-08-26 18:24 ` Rafael J. Wysocki
2010-08-27 23:35 ` Rafael J. Wysocki
2010-09-02 14:31 ` Stephan Diestelhorst
2010-08-17 11:19 ` Rafael J. Wysocki
2010-08-17 11:29 ` Tejun Heo
2010-08-17 12:10 ` Stephan Diestelhorst
2010-08-17 12:09 ` Tejun Heo
2010-08-02 20:48 ` [PATCH] SATA / AHCI: Do not play with the link PM during suspend to RAM (was: Re: HDD not suspending properly / dead on resume) Stephan Diestelhorst
2010-08-02 21:38 ` Rafael J. Wysocki
2010-08-03 8:36 ` Stephan Diestelhorst
2010-08-03 21:13 ` Rafael J. Wysocki
2010-07-10 13:08 ` HDD not suspending properly / dead on resume Rafael J. Wysocki
2010-07-12 15:35 ` Maciej Rutecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C800829.9040802@gmail.com \
--to=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=rjw@sisk.pl \
--cc=stephan.diestelhorst@amd.com \
--cc=stephan.diestelhorst@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).