From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: hibernation hangs with ATA errors (lockup_detector bug) Date: Fri, 03 Sep 2010 10:35:04 +0200 Message-ID: <4C80B338.6020701@gmail.com> References: <4C03C608.1040600@gmail.com> <20100601135004.GP15159@redhat.com> <4C051D44.7040203@gmail.com> <20100602184459.GA15159@redhat.com> <4C0B3E94.6020506@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:34849 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755548Ab0ICIfI (ORCPT ); Fri, 3 Sep 2010 04:35:08 -0400 In-Reply-To: <4C0B3E94.6020506@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Don Zickus Cc: Frederic Weisbecker , LKML , Linux-pm mailing list , linux-ide@vger.kernel.org On 06/06/2010 08:22 AM, Jiri Slaby wrote: > On 06/02/2010 08:44 PM, Don Zickus wrote: >> --- a/kernel/watchdog.c >> +++ b/kernel/watchdog.c >> @@ -550,8 +550,7 @@ cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu) >> break; >> case CPU_ONLINE: >> case CPU_ONLINE_FROZEN: >> - if (watchdog_enable(hotcpu)) >> - return NOTIFY_BAD; >> + watchdog_enable(hotcpu) > > This fixes the problem indeed. Hi, was this fixed somehow? I still use this hunk and don't know if it is needed: --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -524,7 +524,7 @@ cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu) break; case CPU_ONLINE: case CPU_ONLINE_FROZEN: - err = watchdog_enable(hotcpu); + watchdog_enable(hotcpu); break; #ifdef CONFIG_HOTPLUG_CPU case CPU_UP_CANCELED: thanks, -- js