Re: [git patches] libata updates for 2.6.37

[Tejun Heo <tj@kernel.org>]

On 12/01/2010 09:09 PM, Kyle McMartin wrote:
> On Wed, Dec 01, 2010 at 10:50:26AM -0500, Kyle McMartin wrote:
>>> Nothing peculiar.  Hmm... okay, I think I've found what went wrong.
>>> Can you please try the following patch and see whether the problem
>>> goes away?
>>>
>>
>> Thanks, I'll let you know when/if it drops to 1.5gbps.
>>
> 
> Looks to stay at 3.0 Gbps now... but gives up on EH after 5 retries?

Hmmm... something is setting EH_PENDING while EH is in progress.
Let's see what's doing it.  Can you please apply the following patch
on top of the previous one and report the kernel log?

Thanks.

diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 5e59050..8f0d854 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -896,6 +896,10 @@ static void ata_eh_set_pending(struct ata_port *ap, int fastdrain)

 	ap->pflags |= ATA_PFLAG_EH_PENDING;

+	ata_port_printk(ap, KERN_WARNING, "XXX SET EH PENDING, fastdrain=%d\n",
+			fastdrain);
+	dump_stack();
+
 	if (!fastdrain)
 		return;