linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Anssi Hannula <anssi.hannula@iki.fi>
Cc: Jeff Garzik <jeff@garzik.org>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	Mark Lord <kernel@teksavvy.com>
Subject: Re: [PATCH #upstream] ahci: add HFLAG_YES_FBS and apply it to 88SE9128
Date: Wed, 08 Dec 2010 12:10:46 +0100	[thread overview]
Message-ID: <4CFF67B6.7090805@kernel.org> (raw)
In-Reply-To: <4CFE8EE2.1060908@iki.fi>

Hello,

On 12/07/2010 08:45 PM, Anssi Hannula wrote:
>>>> Attached is a patch to make the id entry class-specific. The patch is
>>>> untested (the issue happens in a production machine).
>>>
>>> Thanks a lot for the patch.  It looks correct but it would be great if
>>> it can be veified.
>>
>> I think I can do that later, but probably not this week or so.
> 
> I've now verified that the patch works on a system with 1b4b:9123
> controller.

Thanks for verifying.  Can you please post the kernel log?  Also, do
all ports seem to work?

>>> Also, there's a pending patch to add another PCI
>>> ID for similar marvell controller.  I wonder whether similar
>>> workaround should be applied.  Hmmm... ISTR the other one reporting
>>> IDE class even though it works in IDE mode.
>>
>> IDE class in IDE mode? Isn't that kind of expected? :)

Oh, the latter should have been ahci.

I'm not completely comfortable with going ahead with the patch tho.
It probably is okay but it's still a shot in the dark.  Is there
anyone with marvell contact?

Thanks.

-- 
tejun

  reply	other threads:[~2010-12-08 11:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-24 14:53 [PATCH #upstream] ahci: add HFLAG_YES_FBS and apply it to 88SE9128 Tejun Heo
2010-08-17 21:54 ` Jeff Garzik
2010-11-30  2:04 ` Anssi Hannula
2010-11-30 13:31   ` Tejun Heo
2010-11-30 20:10     ` Anssi Hannula
2010-12-07 19:45       ` Anssi Hannula
2010-12-08 11:10         ` Tejun Heo [this message]
2010-12-08 18:09           ` Jeff Garzik
2010-12-08 18:13             ` Tejun Heo
2011-01-07 19:22               ` Anssi Hannula
2011-01-19  1:07               ` Jeff Garzik
2010-12-20  3:24           ` Anssi Hannula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CFF67B6.7090805@kernel.org \
    --to=tj@kernel.org \
    --cc=anssi.hannula@iki.fi \
    --cc=jeff@garzik.org \
    --cc=kernel@teksavvy.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).