From: Jeff Garzik <jgarzik@pobox.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 1/3] pata_hpt366: coding style cleanup
Date: Fri, 07 Jan 2011 22:34:41 -0500 [thread overview]
Message-ID: <4D27DB51.2050804@pobox.com> (raw)
In-Reply-To: <201012282306.39040.sshtylyov@ru.mvista.com>
On 12/28/2010 03:06 PM, Sergei Shtylyov wrote:
> Fix 2 errors and 11 warnings given by checkpatch.pl:
>
> - *switch* and *case* not on the same indentation level;
>
> - no space between *switch* and open parenthesis;
>
> - drive blacklist arrays not being *const*;
>
> - spaces before tabs;
>
> - lines over 80 characters.
>
> In addition to these changes, also add new line after variable definition in
> hpt36x_init_chipset()...
>
> Signed-off-by: Sergei Shtylyov<sshtylyov@ru.mvista.com>
>
> ---
> The patch is against the recent Linus' tree.
>
> drivers/ata/pata_hpt366.c | 51 ++++++++++++++++++++++++++--------------------
> 1 file changed, 29 insertions(+), 22 deletions(-)
applied 1-3
prev parent reply other threads:[~2011-01-08 3:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-28 20:06 [PATCH 1/3] pata_hpt366: coding style cleanup Sergei Shtylyov
2011-01-08 3:34 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D27DB51.2050804@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).