* [PATCH] pata_hpt37x: actually limit HPT370 to UltraDMA/66
@ 2011-01-05 18:59 Sergei Shtylyov
2011-01-08 3:34 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2011-01-05 18:59 UTC (permalink / raw)
To: jgarzik, linux-ide; +Cc: alan
The driver clearly tries to limit HPT370[A] to UltraDMA/66 if the PCI clock is
less than 50 MHz but due to cut&paste type mistake this code has no effect...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is against the recent Linus' tree plus 2 patches that I posted
before:
http://marc.info/?l=linux-ide&m=129330632207779
http://marc.info/?l=linux-ide&m=129356704826019
drivers/ata/pata_hpt37x.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Index: linux-2.6/drivers/ata/pata_hpt37x.c
===================================================================
--- linux-2.6.orig/drivers/ata/pata_hpt37x.c
+++ linux-2.6/drivers/ata/pata_hpt37x.c
@@ -24,7 +24,7 @@
#include <linux/libata.h>
#define DRV_NAME "pata_hpt37x"
-#define DRV_VERSION "0.6.17"
+#define DRV_VERSION "0.6.18"
struct hpt_clock {
u8 xfer_speed;
@@ -771,20 +771,20 @@ static int hpt37x_init_one(struct pci_de
.udma_mask = ATA_UDMA5,
.port_ops = &hpt370a_port_ops
};
- /* HPT370 - UDMA100 */
+ /* HPT370 - UDMA66 */
static const struct ata_port_info info_hpt370_33 = {
.flags = ATA_FLAG_SLAVE_POSS,
.pio_mask = ATA_PIO4,
.mwdma_mask = ATA_MWDMA2,
- .udma_mask = ATA_UDMA5,
+ .udma_mask = ATA_UDMA4,
.port_ops = &hpt370_port_ops
};
- /* HPT370A - UDMA100 */
+ /* HPT370A - UDMA66 */
static const struct ata_port_info info_hpt370a_33 = {
.flags = ATA_FLAG_SLAVE_POSS,
.pio_mask = ATA_PIO4,
.mwdma_mask = ATA_MWDMA2,
- .udma_mask = ATA_UDMA5,
+ .udma_mask = ATA_UDMA4,
.port_ops = &hpt370a_port_ops
};
/* HPT372 - UDMA133 */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pata_hpt37x: actually limit HPT370 to UltraDMA/66
2011-01-05 18:59 [PATCH] pata_hpt37x: actually limit HPT370 to UltraDMA/66 Sergei Shtylyov
@ 2011-01-08 3:34 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2011-01-08 3:34 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, alan
On 01/05/2011 01:59 PM, Sergei Shtylyov wrote:
> The driver clearly tries to limit HPT370[A] to UltraDMA/66 if the PCI clock is
> less than 50 MHz but due to cut&paste type mistake this code has no effect...
>
> Signed-off-by: Sergei Shtylyov<sshtylyov@ru.mvista.com>
>
> ---
> The patch is against the recent Linus' tree plus 2 patches that I posted
> before:
>
> http://marc.info/?l=linux-ide&m=129330632207779
> http://marc.info/?l=linux-ide&m=129356704826019
>
> drivers/ata/pata_hpt37x.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-08 3:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-05 18:59 [PATCH] pata_hpt37x: actually limit HPT370 to UltraDMA/66 Sergei Shtylyov
2011-01-08 3:34 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).