From: Sergei Shtylyov <sshtylyov@mvista.com>
To: jgarzik@pobox.com, linux-ide@vger.kernel.org
Cc: alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 1/2 v2] pata_hpt366: use pr_warning(...) instead of printk(KERN_WARNING ...)
Date: Mon, 10 Jan 2011 19:12:07 +0300 [thread overview]
Message-ID: <4D2B2FD7.4010607@mvista.com> (raw)
In-Reply-To: <201101101854.17767.sshtylyov@ru.mvista.com>
Hello.
I wrote:
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> ---
> The patch is against the recent Linus' tree plus the patches queued by
> Jeff Garzik in his 'upstream-linus' branch.
> drivers/ata/pata_hpt366.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> Index: linux-2.6/drivers/ata/pata_hpt366.c
> ===================================================================
> --- linux-2.6.orig/drivers/ata/pata_hpt366.c
> +++ linux-2.6/drivers/ata/pata_hpt366.c
> @@ -25,7 +25,7 @@
> #include <linux/libata.h>
>
> #define DRV_NAME "pata_hpt366"
> -#define DRV_VERSION "0.6.9"
> +#define DRV_VERSION "0.6.10"
>
> struct hpt_clock {
> u8 xfer_mode;
> @@ -160,8 +160,8 @@ static int hpt_dma_blacklisted(const str
>
> while (list[i] != NULL) {
> if (!strcmp(list[i], model_num)) {
> - printk(KERN_WARNING DRV_NAME ": %s is not supported for %s.\n",
> - modestr, list[i]);
> + pr_warning(DRV_NAME ": %s is not supported for %s.\n",
> + modestr, list[i]);
> return 1;
> }
> i++;
Disregard this patch -- I've just realized that the 'pata_hpt37x' driver has
a similar fragment and so should be changed by this patch as well, instead of
doing this in patch 2.
WBR, Sergei
prev parent reply other threads:[~2011-01-10 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 15:54 [PATCH 1/2 v2] pata_hpt366: use pr_warning(...) instead of printk(KERN_WARNING ...) Sergei Shtylyov
2011-01-10 16:12 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2B2FD7.4010607@mvista.com \
--to=sshtylyov@mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).