* [PATCH 1/2 v3] pata_hpt{366|37x}: use pr_warning(...) instead of printk(KERN_WARNING ...)
@ 2011-01-10 18:34 Sergei Shtylyov
2011-01-19 0:56 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2011-01-10 18:34 UTC (permalink / raw)
To: jgarzik, linux-ide; +Cc: alan
... in hpt_dma_blacklisted().
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is against the recent Linus' tree plus the patches queued by
Jeff Garzik in his 'upstream-linus' branch.
Changes from the previous version:
- added the similar change for the 'pata_hpt37x' driver...
drivers/ata/pata_hpt366.c | 6 +++---
drivers/ata/pata_hpt37x.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
Index: linux-2.6/drivers/ata/pata_hpt366.c
===================================================================
--- linux-2.6.orig/drivers/ata/pata_hpt366.c
+++ linux-2.6/drivers/ata/pata_hpt366.c
@@ -25,7 +25,7 @@
#include <linux/libata.h>
#define DRV_NAME "pata_hpt366"
-#define DRV_VERSION "0.6.9"
+#define DRV_VERSION "0.6.10"
struct hpt_clock {
u8 xfer_mode;
@@ -160,8 +160,8 @@ static int hpt_dma_blacklisted(const str
while (list[i] != NULL) {
if (!strcmp(list[i], model_num)) {
- printk(KERN_WARNING DRV_NAME ": %s is not supported for %s.\n",
- modestr, list[i]);
+ pr_warning(DRV_NAME ": %s is not supported for %s.\n",
+ modestr, list[i]);
return 1;
}
i++;
Index: linux-2.6/drivers/ata/pata_hpt37x.c
===================================================================
--- linux-2.6.orig/drivers/ata/pata_hpt37x.c
+++ linux-2.6/drivers/ata/pata_hpt37x.c
@@ -24,7 +24,7 @@
#include <linux/libata.h>
#define DRV_NAME "pata_hpt37x"
-#define DRV_VERSION "0.6.18"
+#define DRV_VERSION "0.6.19"
struct hpt_clock {
u8 xfer_speed;
@@ -229,8 +229,8 @@ static int hpt_dma_blacklisted(const str
while (list[i] != NULL) {
if (!strcmp(list[i], model_num)) {
- printk(KERN_WARNING DRV_NAME ": %s is not supported for %s.\n",
- modestr, list[i]);
+ pr_warning(DRV_NAME ": %s is not supported for %s.\n",
+ modestr, list[i]);
return 1;
}
i++;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/2 v3] pata_hpt{366|37x}: use pr_warning(...) instead of printk(KERN_WARNING ...)
2011-01-10 18:34 [PATCH 1/2 v3] pata_hpt{366|37x}: use pr_warning(...) instead of printk(KERN_WARNING ...) Sergei Shtylyov
@ 2011-01-19 0:56 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2011-01-19 0:56 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, alan
On 01/10/2011 01:34 PM, Sergei Shtylyov wrote:
> ... in hpt_dma_blacklisted().
>
> Signed-off-by: Sergei Shtylyov<sshtylyov@ru.mvista.com>
>
> ---
> The patch is against the recent Linus' tree plus the patches queued by
> Jeff Garzik in his 'upstream-linus' branch.
>
> Changes from the previous version:
> - added the similar change for the 'pata_hpt37x' driver...
>
> drivers/ata/pata_hpt366.c | 6 +++---
> drivers/ata/pata_hpt37x.c | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> Index: linux-2.6/drivers/ata/pata_hpt366.c
> ===================================================================
> --- linux-2.6.orig/drivers/ata/pata_hpt366.c
> +++ linux-2.6/drivers/ata/pata_hpt366.c
> @@ -25,7 +25,7 @@
> #include<linux/libata.h>
>
> #define DRV_NAME "pata_hpt366"
> -#define DRV_VERSION "0.6.9"
> +#define DRV_VERSION "0.6.10"
>
> struct hpt_clock {
> u8 xfer_mode;
> @@ -160,8 +160,8 @@ static int hpt_dma_blacklisted(const str
>
> while (list[i] != NULL) {
> if (!strcmp(list[i], model_num)) {
> - printk(KERN_WARNING DRV_NAME ": %s is not supported for %s.\n",
> - modestr, list[i]);
> + pr_warning(DRV_NAME ": %s is not supported for %s.\n",
> + modestr, list[i]);
> return 1;
> }
> i++;
> Index: linux-2.6/drivers/ata/pata_hpt37x.c
> ===================================================================
> --- linux-2.6.orig/drivers/ata/pata_hpt37x.c
> +++ linux-2.6/drivers/ata/pata_hpt37x.c
> @@ -24,7 +24,7 @@
> #include<linux/libata.h>
>
> #define DRV_NAME "pata_hpt37x"
> -#define DRV_VERSION "0.6.18"
> +#define DRV_VERSION "0.6.19"
>
> struct hpt_clock {
> u8 xfer_speed;
> @@ -229,8 +229,8 @@ static int hpt_dma_blacklisted(const str
>
> while (list[i] != NULL) {
> if (!strcmp(list[i], model_num)) {
> - printk(KERN_WARNING DRV_NAME ": %s is not supported for %s.\n",
> - modestr, list[i]);
> + pr_warning(DRV_NAME ": %s is not supported for %s.\n",
> + modestr, list[i]);
Even though I am applying these patches -- forward progress -- I would
encourage you to consider ata_dev_printk() here, since we have the
ata_device pointer available.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-19 0:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-10 18:34 [PATCH 1/2 v3] pata_hpt{366|37x}: use pr_warning(...) instead of printk(KERN_WARNING ...) Sergei Shtylyov
2011-01-19 0:56 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).