From: Jeff Garzik <jgarzik@pobox.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH v2] pata_hpt37x: fold 'if' statement into 'switch'
Date: Tue, 18 Jan 2011 20:00:16 -0500 [thread overview]
Message-ID: <4D3637A0.5060006@pobox.com> (raw)
In-Reply-To: <201101102231.13495.sshtylyov@ru.mvista.com>
On 01/10/2011 02:31 PM, Sergei Shtylyov wrote:
> hpt37x_init_one() has a large *if* statement which should really be folded into
> the *switch* statement that currently constitutes its *else* branch, reducing
> one level of indentation...
>
> Signed-off-by: Sergei Shtylyov<sshtylyov@ru.mvista.com>
>
> ---
> The patch is against the recent Linus' tree plus 2 patches I posted
> before:
>
> http://marc.info/?l=linux-ide&m=129468455026976
> http://marc.info/?l=linux-ide&m=129468485927420
>
> drivers/ata/pata_hpt37x.c | 89 ++++++++++++++++++++++------------------------
> 1 file changed, 43 insertions(+), 46 deletions(-)
applied this, and the prereset inherit patch
prev parent reply other threads:[~2011-01-19 1:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 19:31 [PATCH v2] pata_hpt37x: fold 'if' statement into 'switch' Sergei Shtylyov
2011-01-10 19:34 ` Sergei Shtylyov
2011-01-19 1:00 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3637A0.5060006@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).