From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH #upstream-fixes] pata_mpc52xx: inherit from ata_bmdma_port_ops Date: Tue, 18 Jan 2011 20:00:27 -0500 Message-ID: <4D3637AB.2040202@pobox.com> References: <201101031445.47922.roman.fietze@telemotive.de> <20110103135929.GO18831@htj.dyndns.org> <4D21DD55.2000000@ru.mvista.com> <4D21EAF1.2010504@ru.mvista.com> <4D21FA4D.3030506@mvista.com> <20110109224820.GB26607@mtj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:60886 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752140Ab1ASBAa (ORCPT ); Tue, 18 Jan 2011 20:00:30 -0500 Received: by mail-vw0-f46.google.com with SMTP id 16so130232vws.19 for ; Tue, 18 Jan 2011 17:00:30 -0800 (PST) In-Reply-To: <20110109224820.GB26607@mtj.dyndns.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Sergei Shtylyov , Roman Fietze , linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org On 01/09/2011 05:48 PM, Tejun Heo wrote: > pata_mpc52xx supports BMDMA but inherits ata_sff_port_ops which > triggers BUG_ON() when a DMA command is issued. Fix it. > > Signed-off-by: Tejun Heo > Reported-by: Roman Fietze > Cc: Sergei Shtylyov > Cc: stable@kernel.org > --- > drivers/ata/pata_mpc52xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c > index 8cc536e..d7d8026 100644 > --- a/drivers/ata/pata_mpc52xx.c > +++ b/drivers/ata/pata_mpc52xx.c > @@ -610,7 +610,7 @@ static struct scsi_host_template mpc52xx_ata_sht = { > }; > > static struct ata_port_operations mpc52xx_ata_port_ops = { > - .inherits =&ata_sff_port_ops, > + .inherits =&ata_bmdma_port_ops, > .sff_dev_select = mpc52xx_ata_dev_select, > .set_piomode = mpc52xx_ata_set_piomode, applied