linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phillip Susi <psusi@cfl.rr.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] Export ahci eSATA attribute
Date: Thu, 20 Jan 2011 11:08:25 -0500	[thread overview]
Message-ID: <4D385DF9.6060001@cfl.rr.com> (raw)
In-Reply-To: <4CDEB2C3.20806@cfl.rr.com>

I never got any comment back on this.  In order for udev to use the
existing attribute, it needs to be moved out of the scsi_host device,
and udev needs patched to handle bitwise comparisons, or my simple patch
adding the new attribute can be applied.

Are you certain you do not want to add a new attribute, and if so, would
you accept a patch moving the existing one out of the scsi_host device
so it will be a proper ancestor of the disk device?  Kay Sievers thinks
that the current location of scsi_host is broken should be fixed, but I
think that involves significant changes to the scsi layer so I found
that this patch was much simpler.

On 11/13/2010 10:46 AM, Phillip Susi wrote:
> On 11/13/2010 12:30 AM, Jeff Garzik wrote:
>> As you noted in your previous mail, the entire PORT_CMD is already
>> exported as a attribute. I don't see much point in exporting this
>> information a second time.
> 
> Unfortunately it is not exported in a way that udev can make use of it.
>  Firstly because udev can only compare on specific value matches rather
> than an individual bit, and secondly because it is in the weird
> scsi_host device rather than the host device, so the attribute is not in
> an ancestor device of the disk device.  Placing this attribute this way
> puts it in the ancestry of the disk device so it can be matched by a
> udev ATTRS rule.


      parent reply	other threads:[~2011-01-20 16:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-11  3:32 [PATCH] Export ahci eSATA attribute Phillip Susi
2010-11-11  5:06 ` Jeff Garzik
2010-11-12 15:04   ` Phillip Susi
2010-11-13  5:23   ` Phillip Susi
2010-11-13  5:30     ` Jeff Garzik
2010-11-13 15:46       ` Phillip Susi
2010-11-18 19:37         ` Phillip Susi
2011-01-20 16:08         ` Phillip Susi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D385DF9.6060001@cfl.rr.com \
    --to=psusi@cfl.rr.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).