From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phillip Susi Subject: Re: [PATCH] Export ahci eSATA attribute Date: Thu, 20 Jan 2011 11:08:25 -0500 Message-ID: <4D385DF9.6060001@cfl.rr.com> References: <4CDB63E7.1040106@cfl.rr.com> <4CDB79CA.6000606@garzik.org> <4CDE20CF.3010708@cfl.rr.com> <4CDE2274.8060807@garzik.org> <4CDEB2C3.20806@cfl.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.122]:37013 "EHLO cdptpa-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338Ab1ATQHW (ORCPT ); Thu, 20 Jan 2011 11:07:22 -0500 In-Reply-To: <4CDEB2C3.20806@cfl.rr.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: linux-ide@vger.kernel.org I never got any comment back on this. In order for udev to use the existing attribute, it needs to be moved out of the scsi_host device, and udev needs patched to handle bitwise comparisons, or my simple patch adding the new attribute can be applied. Are you certain you do not want to add a new attribute, and if so, would you accept a patch moving the existing one out of the scsi_host device so it will be a proper ancestor of the disk device? Kay Sievers thinks that the current location of scsi_host is broken should be fixed, but I think that involves significant changes to the scsi layer so I found that this patch was much simpler. On 11/13/2010 10:46 AM, Phillip Susi wrote: > On 11/13/2010 12:30 AM, Jeff Garzik wrote: >> As you noted in your previous mail, the entire PORT_CMD is already >> exported as a attribute. I don't see much point in exporting this >> information a second time. > > Unfortunately it is not exported in a way that udev can make use of it. > Firstly because udev can only compare on specific value matches rather > than an individual bit, and secondly because it is in the weird > scsi_host device rather than the host device, so the attribute is not in > an ancestor device of the disk device. Placing this attribute this way > puts it in the ancestry of the disk device so it can be matched by a > udev ATTRS rule.