linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: viresh kumar <viresh.kumar@st.com>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	Shiraz HASHIM <shiraz.hashim@st.com>,
	Armando VISCONTI <armando.visconti@st.com>,
	amitgoel <amit.goel@st.com>, viresh kumar <viresh.nitj@gmail.com>
Subject: Re: MWDMA Issue: sda: unknown partition table
Date: Mon, 24 Jan 2011 16:50:29 +0530	[thread overview]
Message-ID: <4D3D607D.7030401@st.com> (raw)
In-Reply-To: <20110121163906.GG2832@htj.dyndns.org>

Tejun,

On 01/21/2011 10:09 PM, Tejun Heo wrote:
>> > As suggested by you earlier, i am doing following on card insertion and removal,
>> > after resetting card through controller.
>> > 
>> > 		ata_ehi_hotplugged(ehi);
>> > 		ata_port_freeze(ap);
>> > 
>> > and after that only i get that error message through following path:
>> > Kthread()->scsi_error_handler()->ata_scsi_error()->ata_bmdma_error_handler()
>> > ->ata_sff_error_handler()->ata_do_eh()
> Hmmm... okay, so that's from the hotplugging.
> 
>> > I tried again, but couldn't find why i am getting these two issues:
>> > 	ata1: exception Emask 0x10 SAct 0x0 SErr 0x0 action 0xe frozen
> Yeah, it should be possible to avoid the above if it's coming from
> hotplug.  Identify where and why AC_ERR_ATA_BUS is being set and work
> around it.  There's no reason for it to be set after a hotplug anyway.
> 

I debugged it further, ehi->err_mask |= AC_ERR_ATA_BUS is done in
ata_ehi_hotplugged(). I tried to find the place where it should be cleared in
code path, but couldn't find it.

Further i checked the order in which code is executed and taken dump of that:
ata_ehi_hotplugged, ata_port_freeze, ata_port_abort, ata_do_link_abort,
ata_port_schedule_eh, scsi_schedule_eh.

And just after this following error was printed:
ata1: exception Emask 0x10 SAct 0x0 SErr 0x0 action 0xe frozen

I feel ata_port_schedule_eh() shouldn't have been called. It is called because
there were no qc's in ata_port.

--
viresh

  parent reply	other threads:[~2011-01-24 11:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-21 10:09 MWDMA Issue: sda: unknown partition table viresh kumar
2011-01-21 10:14 ` Tejun Heo
2011-01-21 10:28   ` viresh kumar
2011-01-21 11:59     ` viresh kumar
2011-01-21 16:39       ` Tejun Heo
2011-01-22  4:08         ` Viresh Kumar
2011-01-22 11:45           ` Tejun Heo
2011-01-24 11:20         ` viresh kumar [this message]
2011-02-01 15:32         ` Viresh Kumar
2011-02-01 17:59           ` Eric D. Mudama
2011-02-02  3:43             ` viresh kumar
2011-02-02  5:55               ` Eric D. Mudama
2011-02-02  5:58                 ` viresh kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3D607D.7030401@st.com \
    --to=viresh.kumar@st.com \
    --cc=amit.goel@st.com \
    --cc=armando.visconti@st.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=shiraz.hashim@st.com \
    --cc=tj@kernel.org \
    --cc=viresh.nitj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).