linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide/pmac: housekeeping
Date: Mon, 07 Feb 2011 15:07:07 +0300	[thread overview]
Message-ID: <4D4FE06B.1080705@ru.mvista.com> (raw)
In-Reply-To: <201102071152.19326.bzolnier@gmail.com>

Hello.

On 07-02-2011 13:52, Bartlomiej Zolnierkiewicz wrote:

> * remove legacy IDE_PMAC_DEBUG debugging code
> * rename struct pmac_ide_hwif to struct pmac_ide_priv
> * remove pmac_ide_hwif_t
> * remove needless {dev,pci}_get_drvdata() casts

> Compile-time tested only.

> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
[...]

> Index: b/drivers/ide/pmac.c
> ===================================================================
> --- a/drivers/ide/pmac.c
> +++ b/drivers/ide/pmac.c
[...]
> @@ -698,11 +683,6 @@ set_timings_mdma(ide_drive_t *drive, int
>   		cycleTime = tm[i].cycleTime;
>   		accessTime = tm[i].accessTime;
>   		recTime = tm[i].recoveryTime;
> -
> -#ifdef IDE_PMAC_DEBUG
> -		printk(KERN_ERR "%s: MDMA, cycleTime: %d, accessTime: %d, recTime:
> %d\n",

    Hm, the patch is line-wrapped...

WBR, Sergei

      reply	other threads:[~2011-02-07 12:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07 10:52 [PATCH] ide/pmac: housekeeping Bartlomiej Zolnierkiewicz
2011-02-07 12:07 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D4FE06B.1080705@ru.mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).