linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Joerg Dorchain <joerg@dorchain.net>
Cc: linux-ide@vger.kernel.org
Subject: Re: [Patch] Make suspend/resume work with ich chipset in force AHCI mode
Date: Wed, 16 Feb 2011 14:27:24 +0300	[thread overview]
Message-ID: <4D5BB49C.5060609@ru.mvista.com> (raw)
In-Reply-To: <20110216090709.GR5778@Redstar.dorchain.net>

Hello.

On 16-02-2011 12:07, Joerg Dorchain wrote:

> Hello all,

> this patch in needed in addition to the previous one make
> suspend/resume work in the forced ahci mode.

    This remark should probably follow --- tear line (after the signoff).

> During resume from suspend to ram, the kernel pci layer restores
> the registers for the SATA controller once, then says okay, and
> sets dev->state_saved = false. However, since the restore goes
> from highest address (the BARs [base address registers]) to
> lowest register, some of the higher registers are set as RO
> because according to the lower registers controller is in PIIX
> mode.  This patch introduces a workaround for
> this problem, hacking around the PCI API by setting
> pdev->state_saved = true
> before we do the restore, basically leaving the pci config space
> untouched.

> Bye,

> Joerg

    "Hello" and "bye" shouldn't be the part of the patch description.

> Signed-off-by: joerg Dorchain<joerg@dorchain.net>

    Need space before the email address.

WBR, Sergei

      reply	other threads:[~2011-02-16 11:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-16  9:07 [Patch] Make suspend/resume work with ich chipset in force AHCI mode Joerg Dorchain
2011-02-16 11:27 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5BB49C.5060609@ru.mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=joerg@dorchain.net \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).