From: viresh kumar <viresh.kumar@st.com>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Shiraz HASHIM <shiraz.hashim@st.com>, amitgoel <amit.goel@st.com>,
Armando VISCONTI <armando.visconti@st.com>,
"jgarzik@pobox.com" <jgarzik@pobox.com>,
viresh kumar <viresh.linux@gmail.com>
Subject: Re: [PATCH] pata_arasan_cf: Adding support for arasan compact flash host controller
Date: Fri, 18 Feb 2011 14:48:59 +0530 [thread overview]
Message-ID: <4D5E3983.7050007@st.com> (raw)
In-Reply-To: <20110218091425.GB21209@htj.dyndns.org>
On 02/18/2011 02:44 PM, Tejun Heo wrote:
>> > No. It doesn't have BMDMA. I just wanted to use existing framework and
>> > routines. And i wasn't sure if just overriding qc_issue alone will be enough.
>> > Should i keep it as it is or modify?
> I see. Yeah, if the hardware doesn't really behave like a BMDMA
> controller (and the fact that you need to override every bmdma ops is
> a good indication of that), it usually is much cleaner to inherit from
> sff and implement DMA part in the driver proper. There are several
> drivers like that in the tree.
>
>
>> > Why do these header
>
> files
>>> needed? Unless the driver is gonna be put
>>> > > in multiple .c files, there's no reason to separate out header files.
>>> > >
>> >
>> > Ok. include/linux/pata_arasan_cf_data.h is surely required as it will be
>> > used by platforms also. I kept register macros in a separate file to keep .c
>> > clean. I will merge drivers/ata/pata_arasan_cf.h in .c, if you want me to.
> Yes, please.
Ok.
--
viresh
prev parent reply other threads:[~2011-02-18 9:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 11:34 [PATCH] pata_arasan_cf: Adding support for arasan compact flash host controller Viresh Kumar
2011-02-17 14:52 ` Tejun Heo
2011-02-18 4:39 ` viresh kumar
2011-02-18 9:14 ` Tejun Heo
2011-02-18 9:18 ` viresh kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5E3983.7050007@st.com \
--to=viresh.kumar@st.com \
--cc=amit.goel@st.com \
--cc=armando.visconti@st.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=shiraz.hashim@st.com \
--cc=tj@kernel.org \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).