Re: [PATCH V2 2/2] pata_arasan_cf: Adding support for arasan compact flash host controller

[viresh kumar <viresh.kumar@st.com>]

On 02/18/2011 08:04 PM, Tejun Heo wrote:
> On Fri, Feb 18, 2011 at 05:10:14PM +0530, Viresh Kumar wrote:
>> > +static struct scsi_host_template arasan_cf_sht = {
>> > +	ATA_PIO_SHT(DRIVER_NAME),
>> > +};
> Hmmm... You probably have different requirements for .sg_tablesize and
> .dma_boundary, likely to be more lax.
> 

Tejun,

Actually, we really don't have scatter-gather in our controller.
We have to read/write to the same FIFO address for every 512 bytes, after
which we get buf_avail interrupt. And Controller can do a maximum transfer
of 256 KB after which it gives transfer complete interrupt.

So all sg has to be handled in software, framework or driver.

Also, we will always read/write from/to FIFO. And the external DMA controller
doesn't have any limitation of this dma_boudary.

So i feel i should keep
.sg_tablesize = SG_ALL,
.dma_boundary = 0xFFFFFFFF,

Please correct me if i am wrong.

-- 
viresh