From: viresh kumar <viresh.kumar@st.com>
To: Tejun Heo <tj@kernel.org>
Cc: "jgarzik@pobox.com" <jgarzik@pobox.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Armando VISCONTI <armando.visconti@st.com>,
amitgoel <amit.goel@st.com>
Subject: Re: [PATCH V2 2/2] pata_arasan_cf: Adding support for arasan compact flash host controller
Date: Tue, 22 Feb 2011 12:33:18 +0530 [thread overview]
Message-ID: <4D635FB6.40804@st.com> (raw)
In-Reply-To: <20110218143438.GK21209@htj.dyndns.org>
On 02/18/2011 08:04 PM, Tejun Heo wrote:
> Hmmm... so, now there's a work item which requeues itself. That can't
> be reliably stopped from freeze() as it's called with host lock held
> without process context. I think you should override
> ->error_handler() which looks like the following,
>
> arsan_error_handler(...)
> {
> cancel_work_sync(...);
> cancel_delayed_work_sync(...);
>
> return ata_sff_error_handler(xxx);
> }
Thanks for this. I implemented drivers error_handler and error cases are
working fine now.
--
viresh
prev parent reply other threads:[~2011-02-22 7:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 11:40 [PATCH V2 0/2] add pata_arasan_cf support Viresh Kumar
2011-02-18 11:40 ` [PATCH V1 1/2] libata-sff: add ata_sff_queue_work() & ata_sff_queue_delayed_work() Viresh Kumar
2011-02-18 14:11 ` Tejun Heo
2011-02-18 11:40 ` [PATCH V2 2/2] pata_arasan_cf: Adding support for arasan compact flash host controller Viresh Kumar
2011-02-18 14:34 ` Tejun Heo
2011-02-18 16:58 ` viresh kumar
2011-02-18 17:20 ` ejun Heo
2011-02-19 3:39 ` viresh kumar
2011-02-21 8:31 ` Tejun Heo
2011-02-22 5:46 ` viresh kumar
2011-02-22 8:58 ` Tejun Heo
2011-02-22 7:03 ` viresh kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D635FB6.40804@st.com \
--to=viresh.kumar@st.com \
--cc=amit.goel@st.com \
--cc=armando.visconti@st.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=shiraz.hashim@st.com \
--cc=tj@kernel.org \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).