From: Jeff Garzik <jgarzik@pobox.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Tejun Heo <tj@kernel.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Include WWN ID in inquiry VPD emulation
Date: Mon, 07 Mar 2011 03:27:41 -0500 [thread overview]
Message-ID: <4D7496FD.6040202@pobox.com> (raw)
In-Reply-To: <4D748FF8.1070903@suse.de>
On 03/07/2011 02:57 AM, Hannes Reinecke wrote:
> On 03/04/2011 06:22 PM, Jeff Garzik wrote:
>> And if you're highly motivated, a separate patch to update
>> include/linux/ata.h to return bool for obvious ata_id_has_xxx functions
>> would be nice too.
> Like this?
> -static inline int ata_id_has_fua(const u16 *id)
> +static inline bool ata_id_has_fua(const u16 *id)
> {
> if ((id[ATA_ID_CFSSE] & 0xC000) != 0x4000)
> return 0;
> return id[ATA_ID_CFSSE] & (1 << 6);
> }
Not _quite_ that easy... one must also s/0/false/ and s/1/true/ where
the return value is explicit, rather than the result of an expression.
Jeff
next prev parent reply other threads:[~2011-03-07 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 8:55 [PATCH] libata: Include WWN ID in inquiry VPD emulation Hannes Reinecke
2011-03-04 11:17 ` Sergei Shtylyov
2011-03-04 11:36 ` Hannes Reinecke
2011-03-04 17:09 ` Tejun Heo
2011-03-04 17:22 ` Jeff Garzik
2011-03-07 7:57 ` Hannes Reinecke
2011-03-07 8:27 ` Jeff Garzik [this message]
2011-03-07 8:53 ` Hannes Reinecke
2011-03-14 7:01 ` Jeff Garzik
2011-03-14 15:56 ` Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2011-03-07 7:56 Hannes Reinecke
2011-03-14 7:00 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7496FD.6040202@pobox.com \
--to=jgarzik@pobox.com \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).