From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] libata: Include WWN ID in inquiry VPD emulation Date: Mon, 14 Mar 2011 03:01:49 -0400 Message-ID: <4D7DBD5D.4070803@pobox.com> References: <20110304085501.8B331F90E1@ochil.suse.de> <20110304170904.GW20499@htj.dyndns.org> <4D711FD7.6080507@pobox.com> <4D748FF8.1070903@suse.de> <4D7496FD.6040202@pobox.com> <4D749CFA.3050104@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-vx0-f174.google.com ([209.85.220.174]:43909 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753755Ab1CNHBw (ORCPT ); Mon, 14 Mar 2011 03:01:52 -0400 Received: by vxi39 with SMTP id 39so4071394vxi.19 for ; Mon, 14 Mar 2011 00:01:51 -0700 (PDT) In-Reply-To: <4D749CFA.3050104@suse.de> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Hannes Reinecke Cc: Tejun Heo , linux-ide@vger.kernel.org On 03/07/2011 03:53 AM, Hannes Reinecke wrote: > On 03/07/2011 09:27 AM, Jeff Garzik wrote: >> On 03/07/2011 02:57 AM, Hannes Reinecke wrote: >>> On 03/04/2011 06:22 PM, Jeff Garzik wrote: >>>> And if you're highly motivated, a separate patch to update >>>> include/linux/ata.h to return bool for obvious ata_id_has_xxx functions >>>> would be nice too. >> >>> Like this? >> >>> -static inline int ata_id_has_fua(const u16 *id) >>> +static inline bool ata_id_has_fua(const u16 *id) >>> { >>> if ((id[ATA_ID_CFSSE]& 0xC000) != 0x4000) >>> return 0; >>> return id[ATA_ID_CFSSE]& (1<< 6); >>> } >> >> Not _quite_ that easy... one must also s/0/false/ and s/1/true/ where >> the return value is explicit, rather than the result of an expression. >> > Ok, there you go. looks good, except for the part where it doesn't build ;) Make that micro-fix, and resend as a normal patch, and I'll apply straightaway.