From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ata: pata_at91.c bugfix for initial_timing initialisation Date: Mon, 28 Mar 2011 15:08:48 +0400 Message-ID: <4D906C40.6040104@ru.mvista.com> References: <1301313545-22730-1-git-send-email-plyatov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:55281 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537Ab1C1MKa (ORCPT ); Mon, 28 Mar 2011 08:10:30 -0400 In-Reply-To: <1301313545-22730-1-git-send-email-plyatov@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Igor Plyatov Cc: Jeff Garzik , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Hello. Igor Plyatov wrote: > The "struct ata_timing" must contain 10 members, but ".dmack_hold" member was > forgotten for "initial_timing" initialisation. This patch fixes such a problem. > Signed-off-by: Igor Plyatov > --- > drivers/ata/pata_at91.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c > index 0da0dcc..d1aaeb5 100644 > --- a/drivers/ata/pata_at91.c > +++ b/drivers/ata/pata_at91.c > @@ -49,8 +49,9 @@ struct at91_ide_info { > void __iomem *alt_addr; > }; > > -static const struct ata_timing initial_timing = > - {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0}; > +static const struct ata_timing initial_timing = { > + XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0 > +}; Frankly, I don't see any difference. WBR, Sergei