* [PATCH] ata: pata_at91.c bugfix for initial_timing initialisation
@ 2011-03-28 11:59 Igor Plyatov
2011-03-28 11:08 ` Sergei Shtylyov
2011-03-28 12:09 ` Eric Dumazet
0 siblings, 2 replies; 4+ messages in thread
From: Igor Plyatov @ 2011-03-28 11:59 UTC (permalink / raw)
To: Jeff Garzik, linux-ide; +Cc: linux-kernel, Igor Plyatov
The "struct ata_timing" must contain 10 members, but ".dmack_hold" member was
forgotten for "initial_timing" initialisation. This patch fixes such a problem.
Signed-off-by: Igor Plyatov <plyatov@gmail.com>
---
drivers/ata/pata_at91.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
index 0da0dcc..d1aaeb5 100644
--- a/drivers/ata/pata_at91.c
+++ b/drivers/ata/pata_at91.c
@@ -49,8 +49,9 @@ struct at91_ide_info {
void __iomem *alt_addr;
};
-static const struct ata_timing initial_timing =
- {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0};
+static const struct ata_timing initial_timing = {
+ XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0
+};
static unsigned long calc_mck_cycles(unsigned long ns, unsigned long mck_hz)
{
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ata: pata_at91.c bugfix for initial_timing initialisation
2011-03-28 11:59 [PATCH] ata: pata_at91.c bugfix for initial_timing initialisation Igor Plyatov
@ 2011-03-28 11:08 ` Sergei Shtylyov
2011-03-28 13:01 ` Igor Plyatov
2011-03-28 12:09 ` Eric Dumazet
1 sibling, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2011-03-28 11:08 UTC (permalink / raw)
To: Igor Plyatov; +Cc: Jeff Garzik, linux-ide, linux-kernel
Hello.
Igor Plyatov wrote:
> The "struct ata_timing" must contain 10 members, but ".dmack_hold" member was
> forgotten for "initial_timing" initialisation. This patch fixes such a problem.
> Signed-off-by: Igor Plyatov <plyatov@gmail.com>
> ---
> drivers/ata/pata_at91.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
> diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
> index 0da0dcc..d1aaeb5 100644
> --- a/drivers/ata/pata_at91.c
> +++ b/drivers/ata/pata_at91.c
> @@ -49,8 +49,9 @@ struct at91_ide_info {
> void __iomem *alt_addr;
> };
>
> -static const struct ata_timing initial_timing =
> - {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0};
> +static const struct ata_timing initial_timing = {
> + XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0
> +};
Frankly, I don't see any difference.
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ata: pata_at91.c bugfix for initial_timing initialisation
2011-03-28 11:08 ` Sergei Shtylyov
@ 2011-03-28 13:01 ` Igor Plyatov
0 siblings, 0 replies; 4+ messages in thread
From: Igor Plyatov @ 2011-03-28 13:01 UTC (permalink / raw)
To: Sergei Shtylyov, Eric Dumazet; +Cc: Jeff Garzik, linux-ide, linux-kernel
Dear Sergei and Eric,
It's so stupid from my side to send broken patch, but it happens :-)
Please, look at new my e-mails with subjects:
* "[PATCH v4 1/2] ata: pata_at91.c bugfix for initial_timing
initialisation"
* "[PATCH v4 2/2] ata: pata_at91.c bugfix for high master clock"
Best regards!
--
Igor Plyatov
> Hello.
>
> Igor Plyatov wrote:
>
> > The "struct ata_timing" must contain 10 members, but ".dmack_hold" member was
> > forgotten for "initial_timing" initialisation. This patch fixes such a problem.
>
> > Signed-off-by: Igor Plyatov <plyatov@gmail.com>
> > ---
> > drivers/ata/pata_at91.c | 5 +++--
> > 1 files changed, 3 insertions(+), 2 deletions(-)
>
> > diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
> > index 0da0dcc..d1aaeb5 100644
> > --- a/drivers/ata/pata_at91.c
> > +++ b/drivers/ata/pata_at91.c
> > @@ -49,8 +49,9 @@ struct at91_ide_info {
> > void __iomem *alt_addr;
> > };
> >
> > -static const struct ata_timing initial_timing =
> > - {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0};
> > +static const struct ata_timing initial_timing = {
> > + XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0
> > +};
>
> Frankly, I don't see any difference.
>
> WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ata: pata_at91.c bugfix for initial_timing initialisation
2011-03-28 11:59 [PATCH] ata: pata_at91.c bugfix for initial_timing initialisation Igor Plyatov
2011-03-28 11:08 ` Sergei Shtylyov
@ 2011-03-28 12:09 ` Eric Dumazet
1 sibling, 0 replies; 4+ messages in thread
From: Eric Dumazet @ 2011-03-28 12:09 UTC (permalink / raw)
To: Igor Plyatov; +Cc: Jeff Garzik, linux-ide, linux-kernel
Le lundi 28 mars 2011 à 15:59 +0400, Igor Plyatov a écrit :
> The "struct ata_timing" must contain 10 members, but ".dmack_hold" member was
> forgotten for "initial_timing" initialisation. This patch fixes such a problem.
>
> Signed-off-by: Igor Plyatov <plyatov@gmail.com>
> ---
> drivers/ata/pata_at91.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
> index 0da0dcc..d1aaeb5 100644
> --- a/drivers/ata/pata_at91.c
> +++ b/drivers/ata/pata_at91.c
> @@ -49,8 +49,9 @@ struct at91_ide_info {
> void __iomem *alt_addr;
> };
>
> -static const struct ata_timing initial_timing =
> - {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0};
> +static const struct ata_timing initial_timing = {
> + XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0
Oh well.
XFER_PIO_0, 70, 290, 240, 600, 165, 150, 0, 600, 0
Or even better, use C99 initializer ?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-28 13:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-28 11:59 [PATCH] ata: pata_at91.c bugfix for initial_timing initialisation Igor Plyatov
2011-03-28 11:08 ` Sergei Shtylyov
2011-03-28 13:01 ` Igor Plyatov
2011-03-28 12:09 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).