From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: Commit 7eaceaccab5f40 causing boot hang. Date: Tue, 29 Mar 2011 16:16:58 +0200 Message-ID: <4D91E9DA.4050504@fusionio.com> References: <4D9179EE.9040707@parallels.com> <4D917DB1.9030300@fusionio.com> <4D919DE5.1010509@parallels.com> <4D91E5CE.1080803@fusionio.com> <4D91E912.7060307@parallels.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.fusionio.com ([64.244.102.31]:56033 "EHLO mx2.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753606Ab1C2ORB (ORCPT ); Tue, 29 Mar 2011 10:17:01 -0400 In-Reply-To: <4D91E912.7060307@parallels.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Rob Landley Cc: linux-kernel , "linux-ide@vger.kernel.org" On 2011-03-29 16:13, Rob Landley wrote: > On 03/29/2011 08:59 AM, Jens Axboe wrote: >> On 2011-03-29 10:52, Rob Landley wrote: >>> I'm booting all this under kvm or qemu, by the way: >>> >>> qemu-system-x86_64 -m 1024 -kernel arch/x86/boot/bzImage \ >>> -hda ~/sid.ext3 -append "root=/dev/hda rw" >>> >>> Sometimes with init=/bin/bash in that last quoted bit. The root >>> filesystem's debian sid but that's probably not relevant because it >>> worked fine with .38. >> >> Does this help? >> >> diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c >> index 0e406d73..ca27d30 100644 >> --- a/drivers/ide/ide-io.c >> +++ b/drivers/ide/ide-io.c >> @@ -570,8 +570,7 @@ void ide_requeue_and_plug(ide_drive_t *drive, struct request *rq) >> spin_unlock_irqrestore(q->queue_lock, flags); >> >> /* Use 3ms as that was the old plug delay */ >> - if (rq) >> - blk_delay_queue(q, 3); >> + blk_delay_queue(q, 3); >> } >> >> static int drive_is_ready(ide_drive_t *drive) >> > > Nope, still hung the same way. Funky. I'll try and reproduce this tonight. -- Jens Axboe