From: Randy Dunlap <randy.dunlap@oracle.com>
To: viresh kumar <viresh.kumar@st.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] ata: PATA_ARASAN_CF depends on DMADEVICES
Date: Mon, 23 May 2011 09:21:54 -0700 [thread overview]
Message-ID: <4DDA89A2.8010604@oracle.com> (raw)
In-Reply-To: <4DD9D5EB.3060807@st.com>
On 05/22/11 20:35, viresh kumar wrote:
> On 05/23/2011 06:02 AM, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Fix kconfig unmet dependency warning:
>>
>> warning: (PATA_ARASAN_CF && VIDEO_TIMBERDALE && SND_SOC_SH4_SIU) selects DMA_ENGINE which has unmet direct dependencies (DMADEVICES)
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc: Viresh Kumar <viresh.kumar@st.com>
>> ---
>> drivers/ata/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20110520.orig/drivers/ata/Kconfig
>> +++ linux-next-20110520/drivers/ata/Kconfig
>> @@ -313,6 +313,7 @@ config PATA_AMD
>>
>> config PATA_ARASAN_CF
>> tristate "ARASAN CompactFlash PATA Controller Support"
>> + depends on DMADEVICES
>> select DMA_ENGINE
>
> Randy,
>
> I think we can also remove this "select DMA_ENGINE" line.
In that case, the newly added "depends on" line is not needed either,
since the "select DMA_ENGINE" is what causes the kconfig warning message.
> Otherwise, it looks fine.
>
> Acked-by: Viresh Kumar <viresh.kumar@st.com>
>
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-05-23 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110520165507.cba539d5.sfr@canb.auug.org.au>
2011-05-23 0:32 ` [PATCH -next] ata: PATA_ARASAN_CF depends on DMADEVICES Randy Dunlap
2011-05-23 3:35 ` viresh kumar
2011-05-23 16:21 ` Randy Dunlap [this message]
2011-05-24 3:38 ` viresh kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDA89A2.8010604@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=viresh.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).