* [PATCH -next] ata: PATA_ARASAN_CF depends on DMADEVICES
[not found] <20110520165507.cba539d5.sfr@canb.auug.org.au>
@ 2011-05-23 0:32 ` Randy Dunlap
2011-05-23 3:35 ` viresh kumar
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2011-05-23 0:32 UTC (permalink / raw)
To: Stephen Rothwell, linux-ide, Jeff Garzik; +Cc: linux-next, LKML, Viresh Kumar
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix kconfig unmet dependency warning:
warning: (PATA_ARASAN_CF && VIDEO_TIMBERDALE && SND_SOC_SH4_SIU) selects DMA_ENGINE which has unmet direct dependencies (DMADEVICES)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Viresh Kumar <viresh.kumar@st.com>
---
drivers/ata/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20110520.orig/drivers/ata/Kconfig
+++ linux-next-20110520/drivers/ata/Kconfig
@@ -313,6 +313,7 @@ config PATA_AMD
config PATA_ARASAN_CF
tristate "ARASAN CompactFlash PATA Controller Support"
+ depends on DMADEVICES
select DMA_ENGINE
help
Say Y here to support the ARASAN CompactFlash PATA controller
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] ata: PATA_ARASAN_CF depends on DMADEVICES
2011-05-23 0:32 ` [PATCH -next] ata: PATA_ARASAN_CF depends on DMADEVICES Randy Dunlap
@ 2011-05-23 3:35 ` viresh kumar
2011-05-23 16:21 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: viresh kumar @ 2011-05-23 3:35 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-ide@vger.kernel.org, Jeff Garzik,
linux-next@vger.kernel.org, LKML
On 05/23/2011 06:02 AM, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix kconfig unmet dependency warning:
>
> warning: (PATA_ARASAN_CF && VIDEO_TIMBERDALE && SND_SOC_SH4_SIU) selects DMA_ENGINE which has unmet direct dependencies (DMADEVICES)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Viresh Kumar <viresh.kumar@st.com>
> ---
> drivers/ata/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20110520.orig/drivers/ata/Kconfig
> +++ linux-next-20110520/drivers/ata/Kconfig
> @@ -313,6 +313,7 @@ config PATA_AMD
>
> config PATA_ARASAN_CF
> tristate "ARASAN CompactFlash PATA Controller Support"
> + depends on DMADEVICES
> select DMA_ENGINE
Randy,
I think we can also remove this "select DMA_ENGINE" line.
Otherwise, it looks fine.
Acked-by: Viresh Kumar <viresh.kumar@st.com>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] ata: PATA_ARASAN_CF depends on DMADEVICES
2011-05-23 3:35 ` viresh kumar
@ 2011-05-23 16:21 ` Randy Dunlap
2011-05-24 3:38 ` viresh kumar
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2011-05-23 16:21 UTC (permalink / raw)
To: viresh kumar
Cc: Stephen Rothwell, linux-ide@vger.kernel.org, Jeff Garzik,
linux-next@vger.kernel.org, LKML
On 05/22/11 20:35, viresh kumar wrote:
> On 05/23/2011 06:02 AM, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Fix kconfig unmet dependency warning:
>>
>> warning: (PATA_ARASAN_CF && VIDEO_TIMBERDALE && SND_SOC_SH4_SIU) selects DMA_ENGINE which has unmet direct dependencies (DMADEVICES)
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc: Viresh Kumar <viresh.kumar@st.com>
>> ---
>> drivers/ata/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20110520.orig/drivers/ata/Kconfig
>> +++ linux-next-20110520/drivers/ata/Kconfig
>> @@ -313,6 +313,7 @@ config PATA_AMD
>>
>> config PATA_ARASAN_CF
>> tristate "ARASAN CompactFlash PATA Controller Support"
>> + depends on DMADEVICES
>> select DMA_ENGINE
>
> Randy,
>
> I think we can also remove this "select DMA_ENGINE" line.
In that case, the newly added "depends on" line is not needed either,
since the "select DMA_ENGINE" is what causes the kconfig warning message.
> Otherwise, it looks fine.
>
> Acked-by: Viresh Kumar <viresh.kumar@st.com>
>
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] ata: PATA_ARASAN_CF depends on DMADEVICES
2011-05-23 16:21 ` Randy Dunlap
@ 2011-05-24 3:38 ` viresh kumar
0 siblings, 0 replies; 4+ messages in thread
From: viresh kumar @ 2011-05-24 3:38 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-ide@vger.kernel.org, Jeff Garzik,
linux-next@vger.kernel.org, LKML
On 05/23/2011 09:51 PM, Randy Dunlap wrote:
>>> >> config PATA_ARASAN_CF
>>> >> tristate "ARASAN CompactFlash PATA Controller Support"
>>> >> + depends on DMADEVICES
>>> >> select DMA_ENGINE
>> >
>> > Randy,
>> >
>> > I think we can also remove this "select DMA_ENGINE" line.
> In that case, the newly added "depends on" line is not needed either,
> since the "select DMA_ENGINE" is what causes the kconfig warning message.
>
Some sort of dependency must be present as PATA_ARASAN is using DMAENGINE
routines and it will not compile unless DMA_ENGINE is enabled.
So, depends on DMADEVICES will solve all these issues.
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-05-24 3:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110520165507.cba539d5.sfr@canb.auug.org.au>
2011-05-23 0:32 ` [PATCH -next] ata: PATA_ARASAN_CF depends on DMADEVICES Randy Dunlap
2011-05-23 3:35 ` viresh kumar
2011-05-23 16:21 ` Randy Dunlap
2011-05-24 3:38 ` viresh kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).