Re: [PATCH] ATA: Debugging options for the ATA subsystem

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

Viresh Kumar wrote:

> This adds Kconfig options for DEBUG and VERBOSE_DEBUG to the ATA subsystem

> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
> ---
>  drivers/ata/Kconfig  |   14 ++++++++++++++
>  drivers/ata/Makefile |    2 ++
>  2 files changed, 16 insertions(+), 0 deletions(-)

> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 75afa75..d527fbe 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -30,6 +30,20 @@ menuconfig ATA
>  
>  if ATA
>  
> +config ATA_DEBUG
> +        bool "ATA debugging"
> +        help
> +          This is an option for use by developers; most people should
> +          say N here.  This enables ATA core and driver debugging.
> +
> +config ATA_VDEBUG
> +        bool "ATA verbose debugging"
> +        depends on ATA_DEBUG != n

    Why not just on ATA_DEBUG? It can only be 'y' or 'n'.

WBR, Sergei