From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Yuan-Hsin Chen <yuanlmm@gmail.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, tj@kernel.org,
sshtylyov@mvista.com, Yuan-Hsin Chen <yhchen@faraday-tech.com>
Subject: Re: [PATCH v4] ahci: move ahci_sb600_softreset to libahci.c and rename it
Date: Mon, 20 Jun 2011 12:15:23 +0400 [thread overview]
Message-ID: <4DFF019B.8030605@ru.mvista.com> (raw)
In-Reply-To: <1308557202-1895-1-git-send-email-yuanlmm@gmail.com>
Hello.
On 20-06-2011 12:06, Yuan-Hsin Chen wrote:
> From: Yuan-Hsin Chen<yhchen@faraday-tech.com>
> ahci_sb600_softreset was in ahci.c. This function is used
> to fix soft reset failure and renames as ahci_pmp_retry_srst_softreset
> in libahci.c.
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 71afe03..2de36b6 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -79,8 +79,6 @@ enum board_ids {
> };
>
> static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
> -static int ahci_sb600_softreset(struct ata_link *link, unsigned int *class,
> - unsigned long deadline);
> static int ahci_vt8251_hardreset(struct ata_link *link, unsigned int *class,
> unsigned long deadline);
> static int ahci_p5wdh_hardreset(struct ata_link *link, unsigned int *class,
> @@ -106,8 +104,7 @@ static struct ata_port_operations ahci_p5wdh_ops = {
>
> static struct ata_port_operations ahci_sb600_ops = {
> .inherits =&ahci_ops,
> - .softreset = ahci_sb600_softreset,
> - .pmp_softreset = ahci_sb600_softreset,
> + .softreset = ahci_pmp_retry_srst_softreset,
I have to ask you again: have you tried to compile this?
> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
> index d38c40f..0fd5a30 100644
> --- a/drivers/ata/libahci.c
> +++ b/drivers/ata/libahci.c
> @@ -82,6 +82,8 @@ static void ahci_pmp_attach(struct ata_port *ap);
> static void ahci_pmp_detach(struct ata_port *ap);
> static int ahci_softreset(struct ata_link *link, unsigned int *class,
> unsigned long deadline);
> +static int ahci_pmp_retry_srst_softreset(struct ata_link *link, unsigned int *class,
> + unsigned long deadline);
How come this is static if you reference it outside this module?
WBR, Sergei
next prev parent reply other threads:[~2011-06-20 8:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 5:48 [PATCH] ahci: enable pmp but connected to HDD issue fixed Yuan-Hsin Chen
2011-06-14 6:52 ` Tejun Heo
2011-06-15 10:04 ` [PATCH v2] ahci: fix pmp softreset with HDD Yuan-Hsin Chen
2011-06-15 10:14 ` Tejun Heo
2011-06-17 10:39 ` [PATCH v3] ahci: move ahci_sb600_softreset to libahci.c and rename it Yuan-Hsin Chen
2011-06-17 11:34 ` Sergei Shtylyov
2011-06-17 12:07 ` Tejun Heo
2011-06-20 8:06 ` [PATCH v4] " Yuan-Hsin Chen
2011-06-20 8:15 ` Sergei Shtylyov [this message]
2011-06-20 8:47 ` Yuan-Hsin Chen
2011-06-20 8:19 ` Tejun Heo
2011-06-20 10:06 ` Yuan-Hsin Chen
2011-06-20 12:47 ` Tejun Heo
2011-06-21 3:24 ` Yuan-Hsin Chen
2011-06-21 7:17 ` Tejun Heo
2011-06-21 9:17 ` [PATCH v5] " Yuan-Hsin Chen
2011-06-21 9:53 ` Tejun Heo
[not found] ` <BANLkTimiJheFauWXjh-8GszGHoqMOa0Kkw@mail.gmail.com>
2011-06-15 2:50 ` Fwd: [PATCH] ahci: enable pmp but connected to HDD issue fixed BingJiun Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFF019B.8030605@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yhchen@faraday-tech.com \
--cc=yuanlmm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).