From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 05/35] drivers/ata changes for SMBIOS and System Firmware Date: Thu, 23 Jun 2011 17:33:04 -0400 Message-ID: <4E03B110.7060708@garzik.org> References: <20110623172240.27628.71518.sendpatchset@prarit.bos.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:50169 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759815Ab1FWVdH (ORCPT ); Thu, 23 Jun 2011 17:33:07 -0400 In-Reply-To: <20110623172240.27628.71518.sendpatchset@prarit.bos.redhat.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Prarit Bhargava Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org On 06/23/2011 01:22 PM, Prarit Bhargava wrote: > drivers/ata changes for SMBIOS and System Firmware > > As part of the new SMBIOS and System Firmware code: > > - Replace old dmi* structures and functions with new sysfw* and smbios* > structures and functions in individual drivers > - cleanup sysfw_id lookup tables > - cleanup of includes for dmi.h and mod_devicetable.h which were included in > some files that did not need them > > Signed-off-by: Prarit Bhargava > --- > drivers/ata/acard-ahci.c | 1 - > drivers/ata/ahci.c | 177 +++++++++++++++++++++++---------------------- > drivers/ata/ata_piix.c | 156 +++++++++++++++++++++++----------------- > drivers/ata/pata_ali.c | 18 +++--- > drivers/ata/pata_cs5530.c | 12 ++-- > drivers/ata/pata_rdc.c | 1 - > drivers/ata/pata_sch.c | 1 - > drivers/ata/pata_via.c | 14 ++-- > drivers/ata/sata_sil.c | 19 +++--- > 9 files changed, 210 insertions(+), 189 deletions(-) > #ifdef CONFIG_PM > +bool sysfw_match(int field, const char *str) > +{ > + const char *info = sysfw_lookup(field); > + > + if (info == NULL || str == NULL) > + return info == str; > + > + return !strcmp(info, str); > +} It is surprising that nobody else needed this. I would rather that this sort of thing go into the generic code, where it lived prior to this change. Either way, though, Acked-by: Jeff Garzik I presume you'll merge this at the same time as the rest of the rename changes.