From: Mark Lord <mlord@pobox.com>
To: Gwendal Grignou <gwendal@google.com>
Cc: Tejun Heo <tj@kernel.org>, Marc MERLIN <marc@merlins.org>,
linux-ide@vger.kernel.org, Larry Li <lil@marvell.com>,
hbailey@marvell.com
Subject: Re: sata_mv WARNING: at drivers/ata/libata-sff.c:1322
Date: Wed, 13 Jul 2011 18:41:22 -0400 [thread overview]
Message-ID: <4E1E1F12.8040100@pobox.com> (raw)
In-Reply-To: <CAMHSBOWrU0MRuDOvAsU-=hqZnZrRp2ry6zvYTH0M8kwXfopryQ@mail.gmail.com>
On 11-07-13 04:54 PM, Gwendal Grignou wrote:
> I put the warning because a new pio task should not be queued while
> another one is pending. Therefore, either sff_pio_task_link is NULL
> [no task pending] or sff_pio_task_link is equal to the link of the
> task [assumed to be the task in progress].
> I must have missed something and did not cleanup sff_pio_task_link
> properly in case of error...
..
I wonder if any of those changes are what broke PMP support?
I have a Marvell PMP here that used to work when I finished with sata_mv,
but no longer works with it now.
??
--
Mark Lord
Real-Time Remedies Inc.
mlord@pobox.com
next prev parent reply other threads:[~2011-07-13 22:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-26 7:08 decoding PMP errors with Marvel SATA controller Marc MERLIN
2011-06-26 9:03 ` Tejun Heo
2011-06-26 17:38 ` Mark Lord
2011-06-27 0:06 ` Marc MERLIN
2011-06-27 1:29 ` Mark Lord
2011-06-27 1:58 ` Hubert Bailey
2011-07-06 20:55 ` Tim Small
2011-06-29 3:41 ` Marc MERLIN
2011-06-29 3:53 ` Mark Lord
2011-06-29 5:03 ` Marc MERLIN
2011-06-29 15:07 ` sata_mv WARNING: at drivers/ata/libata-sff.c:1322 Marc MERLIN
2011-06-29 16:03 ` Mark Lord
2011-07-12 14:29 ` Tejun Heo
2011-07-13 20:54 ` Gwendal Grignou
2011-07-13 22:41 ` Mark Lord [this message]
2011-07-14 7:19 ` Gwendal Grignou
2011-07-14 12:03 ` Mark Lord
2011-07-15 15:55 ` Marc MERLIN
2011-07-16 0:32 ` [PATCH] Prevent warning during PMP error recovery Gwendal Grignou
2011-07-16 0:34 ` Gwendal Grignou
2011-07-21 7:24 ` Tejun Heo
2011-07-21 7:25 ` Tejun Heo
2011-07-22 20:48 ` Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1E1F12.8040100@pobox.com \
--to=mlord@pobox.com \
--cc=gwendal@google.com \
--cc=hbailey@marvell.com \
--cc=lil@marvell.com \
--cc=linux-ide@vger.kernel.org \
--cc=marc@merlins.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).