From: Jeff Garzik <jgarzik@pobox.com>
To: Greg Dietsche <gregory.dietsche@cuw.edu>
Cc: linux-ide@vger.kernel.org, kernel-janitors@vger.kernel.org,
tj@kernel.org
Subject: Re: [PATCH] ata: remove unnecessary code
Date: Tue, 19 Jul 2011 22:10:03 -0400 [thread overview]
Message-ID: <4E2638FB.4080103@pobox.com> (raw)
In-Reply-To: <4E263769.9040500@cuw.edu>
On 07/19/2011 10:03 PM, Greg Dietsche wrote:
>
>
> On 06/16/2011 11:39 AM, Greg Dietsche wrote:
>> Compile tested.
>> remove unnecessary code that matches this coccinelle pattern
>> if (...)
>> return ret;
>> return ret;
>>
>> Signed-off-by: Greg Dietsche<Gregory.Dietsche@cuw.edu>
>
> Acked-by: Tejun Heo<tj@kernel.org>
>
>
>> ---
>> drivers/ata/pata_acpi.c | 8 +-------
>> 1 files changed, 1 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
>> index 91949d9..54145ed 100644
>> --- a/drivers/ata/pata_acpi.c
>> +++ b/drivers/ata/pata_acpi.c
>> @@ -195,8 +195,6 @@ static int pacpi_port_start(struct ata_port *ap)
>> struct pci_dev *pdev = to_pci_dev(ap->host->dev);
>> struct pata_acpi *acpi;
>>
>> - int ret;
>> -
>> if (ap->acpi_handle == NULL)
>> return -ENODEV;
>>
>> @@ -205,11 +203,7 @@ static int pacpi_port_start(struct ata_port *ap)
>> return -ENOMEM;
>> acpi->mask[0] = pacpi_discover_modes(ap,&ap->link.device[0]);
>> acpi->mask[1] = pacpi_discover_modes(ap,&ap->link.device[1]);
>> - ret = ata_bmdma_port_start(ap);
>> - if (ret< 0)
>> - return ret;
>> -
>> - return ret;
>> + return ata_bmdma_port_start(ap);
>> }
>>
>> static struct scsi_host_template pacpi_sht = {
> This was acked by TJ, but seems to be lost in the shuffle thus far. I'm
> adding trivial@kernel.org to the cc list since this is trivial and no
> one has picked up this patch to date.
It's in libata-dev, so it's been picked up...
We are in -rc, so it won't show up in a kernel until 3.0 is released,
and the merge window opens again.
Jeff
next prev parent reply other threads:[~2011-07-20 2:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 16:39 [PATCH] ata: remove unnecessary code Greg Dietsche
2011-07-09 15:21 ` Greg Dietsche
2011-07-12 14:17 ` Tejun Heo
2011-07-20 2:03 ` Greg Dietsche
2011-07-20 2:04 ` Greg Dietsche
2011-07-20 2:10 ` Jeff Garzik [this message]
2011-07-20 2:14 ` Greg Dietsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2638FB.4080103@pobox.com \
--to=jgarzik@pobox.com \
--cc=gregory.dietsche@cuw.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).