Re: [PATCH Resend] ATA: Debugging options for the ATA subsystem

[Jeff Garzik <jgarzik@pobox.com>]

On 06/08/2011 11:56 PM, Viresh Kumar wrote:
> This adds Kconfig options for DEBUG and VERBOSE_DEBUG to the ATA subsystem
>
> Signed-off-by: Viresh Kumar<viresh.kumar@st.com>
> ---
>   drivers/ata/Kconfig  |   14 ++++++++++++++
>   drivers/ata/Makefile |    2 ++
>   2 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 5dd1e4c..e1ac908 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -22,6 +22,20 @@ menuconfig ATA
>
>   if ATA
>
> +config ATA_DEBUG
> +        bool "ATA debugging"
> +        help
> +          This is an option for use by developers; most people should
> +          say N here.  This enables ATA core and driver debugging.
> +
> +config ATA_VDEBUG
> +        bool "ATA verbose debugging"
> +        depends on ATA_DEBUG
> +        help
> +          This is an option for use by developers; most people should
> +          say N here.  This enables deeper (more verbose) debugging of
> +          the ATA core and drivers.
> +

There does not seem to be a large, driving need for this.  It is 
straightforward to update the header file for the esoteric, voluminous 
debugging.

If you are missing critical hardware or software errors, that is an 
argument that those error messages should be outside of DEBUG/VDEBUG, 
shipped with every kernel.

	Jeff