From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_atiixp: add proper ->prereset method
Date: Wed, 12 Oct 2011 14:31:59 +0400 [thread overview]
Message-ID: <4E956C9F.6070304@mvista.com> (raw)
In-Reply-To: <201110111955.09320.bzolnier@gmail.com>
Hello.
On 11-10-2011 21:55, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> Subject: [PATCH] pata_atiixp: add proper ->prereset method
> Fixes PCI access before PCI resources are allocated.
Hm, didn't understand this...
> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> ---
> earlier references:
> https://lkml.org/lkml/2009/11/25/320
> drivers/ata/pata_atiixp.c | 35 ++++++++++++++++++++++++++---------
> 1 file changed, 26 insertions(+), 9 deletions(-)
> Index: b/drivers/ata/pata_atiixp.c
> ===================================================================
> --- a/drivers/ata/pata_atiixp.c
> +++ b/drivers/ata/pata_atiixp.c
[...]
> @@ -235,16 +261,7 @@ static int atiixp_init_one(struct pci_de
> .udma_mask = ATA_UDMA5,
> .port_ops =&atiixp_port_ops
> };
> - static const struct pci_bits atiixp_enable_bits[] = {
> - { 0x48, 1, 0x01, 0x00 },
> - { 0x48, 1, 0x08, 0x00 }
> - };
> const struct ata_port_info *ppi[] = {&info,&info };
> - int i;
> -
> - for (i = 0; i< 2; i++)
> - if (!pci_test_config_bits(pdev,&atiixp_enable_bits[i]))
> - ppi[i] =&ata_dummy_port_info;
But this seems more safe method than prereset() as it should really avoid
accessing the disabled IDE ports (which blows up on non-x86)... didn't
understand why this is incorrect...
WBR, Sergei
prev parent reply other threads:[~2011-10-12 10:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 17:55 [PATCH] pata_atiixp: add proper ->prereset method Bartlomiej Zolnierkiewicz
2011-10-11 19:57 ` Alan Cox
2011-10-12 10:31 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E956C9F.6070304@mvista.com \
--to=sshtylyov@mvista.com \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).