From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] pata_sil680: minor CodingStyle fixups
Date: Wed, 12 Oct 2011 14:48:32 +0400 [thread overview]
Message-ID: <4E957080.6020102@mvista.com> (raw)
In-Reply-To: <201110112021.51236.bzolnier@gmail.com>
Hello.
On 11-10-2011 22:21, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> Subject: [PATCH] pata_sil680: minor CodingStyle fixups
> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> ---
> drivers/ata/pata_sil680.c | 58 ++++++++++++++++++++++++++--------------------
> 1 file changed, 33 insertions(+), 25 deletions(-)
> Index: b/drivers/ata/pata_sil680.c
> ===================================================================
> --- a/drivers/ata/pata_sil680.c
> +++ b/drivers/ata/pata_sil680.c
[...]
> @@ -265,12 +266,19 @@ static u8 sil680_init_chip(struct pci_de
> pci_write_config_dword(pdev, 0xB8, 0x43924392);
> pci_write_config_dword(pdev, 0xBC, 0x40094009);
>
> - switch(tmpbyte& 0x30) {
> - case 0x00: printk(KERN_INFO "sil680: 100MHz clock.\n");break;
> - case 0x10: printk(KERN_INFO "sil680: 133MHz clock.\n");break;
> - case 0x20: printk(KERN_INFO "sil680: Using PCI clock.\n");break;
> - /* This last case is _NOT_ ok */
> - case 0x30: printk(KERN_ERR "sil680: Clock disabled ?\n");
> + switch (tmpbyte& 0x30) {
> + case 0x00:
> + printk(KERN_INFO "sil680: 100MHz clock.\n");
> + break;
> + case 0x10:
> + printk(KERN_INFO "sil680: 133MHz clock.\n");
> + break;
> + case 0x20:
> + printk(KERN_INFO "sil680: Using PCI clock.\n");
> + break;
pr_info() here and above?
> + /* This last case is _NOT_ ok */
> + case 0x30:
> + printk(KERN_ERR "sil680: Clock disabled ?\n");
pr_err()? Or checkpatch.pl doesn't complain about it (I forgot)?
WBR, Sergei
next prev parent reply other threads:[~2011-10-12 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 18:21 [PATCH 3/3] pata_sil680: minor CodingStyle fixups Bartlomiej Zolnierkiewicz
2011-10-11 19:47 ` Alan Cox
2011-10-12 10:48 ` Sergei Shtylyov [this message]
2011-10-12 11:03 ` Alan Cox
2011-10-14 16:45 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E957080.6020102@mvista.com \
--to=sshtylyov@mvista.com \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).