From: Viresh Kumar <viresh.kumar@st.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"jgarzik@pobox.com" <jgarzik@pobox.com>,
Shiraz HASHIM <shiraz.hashim@st.com>
Subject: Re: [PATCH] pata_arasan_cf: remove bogus to_platform_device() calls
Date: Thu, 13 Oct 2011 09:03:50 +0530 [thread overview]
Message-ID: <4E965C1E.2080606@st.com> (raw)
In-Reply-To: <201110121909.09664.sshtylyov@ru.mvista.com>
On 10/12/2011 8:39 PM, Sergei Shtylyov wrote:
> The suspend()/resume() methods already get the right 'struct device' to get the
> driver data from -- there's no need to get to the 'struct platform_device' that
> contains that 'struct device' just to call dev_get_drvdata()...
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> ---
> This patch is against the recent Linus' tree.
>
> drivers/ata/pata_arasan_cf.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> Index: linux-2.6/drivers/ata/pata_arasan_cf.c
> ===================================================================
> --- linux-2.6.orig/drivers/ata/pata_arasan_cf.c
> +++ linux-2.6/drivers/ata/pata_arasan_cf.c
> @@ -922,8 +922,7 @@ static int __devexit arasan_cf_remove(st
> #ifdef CONFIG_PM
> static int arasan_cf_suspend(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct ata_host *host = dev_get_drvdata(&pdev->dev);
> + struct ata_host *host = dev_get_drvdata(dev);
> struct arasan_cf_dev *acdev = host->ports[0]->private_data;
>
> if (acdev->dma_chan) {
> @@ -937,8 +936,7 @@ static int arasan_cf_suspend(struct devi
>
> static int arasan_cf_resume(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct ata_host *host = dev_get_drvdata(&pdev->dev);
> + struct ata_host *host = dev_get_drvdata(dev);
> struct arasan_cf_dev *acdev = host->ports[0]->private_data;
>
> cf_init(acdev);
> .
>
Acked-by: Viresh Kumar <viresh.kumar@st.com>
--
viresh
prev parent reply other threads:[~2011-10-13 3:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 15:09 [PATCH] pata_arasan_cf: remove bogus to_platform_device() calls Sergei Shtylyov
2011-10-13 3:33 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E965C1E.2080606@st.com \
--to=viresh.kumar@st.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=shiraz.hashim@st.com \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).