From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH v2 3/4] ata_piix: CodingStyle fixes Date: Fri, 14 Oct 2011 13:36:16 -0400 Message-ID: <4E987310.1050401@pobox.com> References: <201110131543.30235.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qy0-f181.google.com ([209.85.216.181]:61574 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932272Ab1JNRgS (ORCPT ); Fri, 14 Oct 2011 13:36:18 -0400 In-Reply-To: <201110131543.30235.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On 10/13/2011 09:43 AM, Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH] ata_piix: CodingStyle fixes > > CodingStyle fixes for piix_port_info[]. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/ata/ata_piix.c | 68 ++++++++++++++----------------------------------- > 1 file changed, 20 insertions(+), 48 deletions(-) > > Index: b/drivers/ata/ata_piix.c > =================================================================== > --- a/drivers/ata/ata_piix.c > +++ b/drivers/ata/ata_piix.c > @@ -473,131 +473,103 @@ static const struct piix_map_db *piix_ma > }; > > static struct ata_port_info piix_port_info[] = { > - [piix_pata_mwdma] = /* PIIX3 MWDMA only */ > - { > + [piix_pata_mwdma] = { /* PIIX3 MWDMA only */ > .flags = PIIX_PATA_FLAGS, > .pio_mask = ATA_PIO4, > - .mwdma_mask = ATA_MWDMA12_ONLY, /* mwdma1-2 ?? CHECK 0 should be ok but slow */ > + .mwdma_mask = ATA_MWDMA12_ONLY, /* check if MWDMA0 is OK */ > .port_ops =&piix_pata_ops, > }, Having been the perpetrator of this "awful" coding style, I think it is fine and more readable as-is... :)