linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Paul Schilling <paul.s.schilling@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 01/14] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug.
Date: Sat, 22 Oct 2011 00:12:25 -0400	[thread overview]
Message-ID: <4EA242A9.3060300@pobox.com> (raw)
In-Reply-To: <1319254458-4692-1-git-send-email-paul.s.schilling@gmail.com>

On 10/21/2011 11:34 PM, Paul Schilling wrote:
> This fixes a DMA issue related to a CRC bug on
> the RDC pata peripherial found on the vortex86sx and vortex86dx.
>
> Signed-off-by: Paul Schilling<paul.s.schilling@gmail.com>

I'm sorry, this is not acceptable.

You missed in hundreds of lines of useless reformatting in amongst the 
fixes.

Please separate out logical changes - thus, any whitespace/reformatting 
must be in a separate patch from your fixes.




      reply	other threads:[~2011-10-22  4:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Vortex86_PATA>
2011-10-22  3:34 ` [PATCH 01/14] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug Paul Schilling
2011-10-22  4:12   ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA242A9.3060300@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=davem@davemloft.net \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=paul.s.schilling@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).