From: Jeff Garzik <jeff@garzik.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Tejun Heo <tj@kernel.org>, linux-ide@vger.kernel.org
Subject: Re: libata SFF and BDBMA
Date: Sun, 20 Nov 2011 20:16:51 -0500 [thread overview]
Message-ID: <4EC9A683.5000005@garzik.org> (raw)
In-Reply-To: <20111120140751.GA21394@x1.osrc.amd.com>
On 11/20/2011 09:07 AM, Borislav Petkov wrote:
> Hi,
>
> I managed to cause the following build breakage on current -linus with
> the attached config:
>
> drivers/ata/libata-sff.c: In function ‘ata_pci_init_one’:
> drivers/ata/libata-sff.c:2538:3: error: implicit declaration of function ‘ata_pci_bmdma_prepare_host’ [-Werror=implicit-function-declaration]
> drivers/ata/libata-sff.c:2549:40: error: ‘ata_bmdma_interrupt’ undeclared (first use in this function)
> drivers/ata/libata-sff.c:2549:40: note: each undeclared identifier is reported only once for each function it appears in
> cc1: some warnings being treated as errors
>
> make[2]: *** [drivers/ata/libata-sff.o] Error 1
> make[1]: *** [drivers/ata] Error 2
> make: *** [drivers] Error 2
> make: *** Waiting for unfinished jobs....
>
> due to the fact that CONFIG_ATA_BMDMA is not set. From where I'm
> standing this needs either stubs for the missing functions in the
> include/linux/libata.h header for the case where CONFIG_ATA_BMDMA is not
> set, or make CONFIG_ATA_SFF depend on CONFIG_ATA_BMDMA or select it or
> whatever makes most sense.
The fix has been in libata-dev (and thus linux-next) for a couple days,
and will go to Linus tonight or tomorrow.
Jeff
prev parent reply other threads:[~2011-11-21 1:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 14:07 libata SFF and BDBMA Borislav Petkov
2011-11-21 1:16 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC9A683.5000005@garzik.org \
--to=jeff@garzik.org \
--cc=bp@alien8.de \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).