From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v4 6/6] ata: add ata port runtime PM callbacks Date: Mon, 28 Nov 2011 14:13:19 +0400 Message-ID: <4ED35EBF.6030602@mvista.com> References: <1322442950-16268-1-git-send-email-ming.m.lin@intel.com> <1322442950-16268-7-git-send-email-ming.m.lin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1322442950-16268-7-git-send-email-ming.m.lin@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Lin Ming Cc: Jeff Garzik , James Bottomley , Alan Stern , Tejun Heo , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Huang Ying , Zhang Rui List-Id: linux-ide@vger.kernel.org Hello. On 28-11-2011 5:15, Lin Ming wrote: > Add ata port runtime suspend/resume/idle callbacks. > Set ->eh_noresume to skip the runtime PM calls on scsi host > in the error handler to avoid dead lock. > Signed-off-by: Lin Ming > --- > drivers/ata/libata-core.c | 10 ++++++++++ > drivers/ata/libata-scsi.c | 1 + > drivers/ata/libata-transport.c | 4 ++++ > 3 files changed, 15 insertions(+), 0 deletions(-) > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c > index 04c208e..15a3d4d 100644 > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c [...] > @@ -5307,9 +5308,18 @@ static int ata_port_resume(struct device *dev) > return rc; > } > > +static int ata_port_runtime_idle(struct device *dev) > +{ > + return pm_runtime_suspend(dev); > +} > + > static const struct dev_pm_ops ata_port_pm_ops = { > .suspend = ata_port_suspend, > .resume = ata_port_resume, > + > + .runtime_suspend = ata_port_suspend_common, > + .runtime_resume = ata_port_resume, > + .runtime_idle = ata_port_runtime_idle, Can't use set this to pm_runtime_suspend directly? MBR, Sergei