From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Zhang Rui <rui.zhang@intel.com>, Jeff Garzik <jgarzik@pobox.com>,
Alan Stern <stern@rowland.harvard.edu>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Tejun Heo <tj@kernel.org>,
Aaron Lu <aaron.lu@amd.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org,
linux-acpi <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v3 4/7] libata: detech Device Attention support
Date: Wed, 28 Mar 2012 15:22:05 +0400 [thread overview]
Message-ID: <4F72F45D.7090800@mvista.com> (raw)
In-Reply-To: <1332915722-15963-5-git-send-email-ming.m.lin@intel.com>
Hello.
On 28-03-2012 10:21, Lin Ming wrote:
> Add a new flag ATA_DFLAG_DA to indicate that device supports "Device
> Attention".
> Acked-by: Aaron Lu<aaron.lu@amd.com>
> Signed-off-by: Lin Ming<ming.m.lin@intel.com>
[...]
> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index 32df2b6..6ee41cc 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -578,6 +578,7 @@ static inline int ata_is_data(u8 prot)
> ((u64) (id)[(n) + 0]) )
>
> #define ata_id_cdb_intr(id) (((id)[ATA_ID_CONFIG]& 0x60) == 0x20)
> +#define atapi_id_has_da(id) ((id)[77]& (1<< 4))
We prefix these macros with 'ata_' despite them being applied to IDENTIFY
DEVICE data or IDENTIFY PAKCET DEVICE data. ata_id_cdb_intr(), for example,
applies only to IDENTIFY PAKCET DEVICE data.
MBR, Sergei
next prev parent reply other threads:[~2012-03-28 11:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 6:21 [PATCH v3 0/7] SATA ZPODD support Lin Ming
2012-03-28 6:21 ` [PATCH v3 1/7] libata-acpi: set acpi state for SATA port Lin Ming
2012-03-28 19:55 ` Aaron Lu
2012-03-28 7:57 ` Lin Ming
2012-03-28 6:21 ` [PATCH v3 2/7] libata-acpi: add ata port runtime D3Cold support Lin Ming
2012-03-28 6:21 ` [PATCH v3 3/7] libata-acpi: register/unregister device to/from power resource Lin Ming
2012-03-28 6:21 ` [PATCH v3 4/7] libata: detech Device Attention support Lin Ming
2012-03-28 11:22 ` Sergei Shtylyov [this message]
2012-03-29 5:06 ` Lin Ming
2012-03-29 11:14 ` Sergei Shtylyov
2012-03-29 11:18 ` Lin Ming
2012-03-28 6:22 ` [PATCH v3 5/7] libata: tell scsi layer device supports runtime power off Lin Ming
2012-03-28 6:22 ` [PATCH v3 6/7] PM / Runtime: Add can_power_off flag to subsys data Lin Ming
2012-03-28 6:22 ` [PATCH v3 7/7] [SCSI] sr: adds Zero-power ODD support Lin Ming
2012-03-28 14:33 ` Alan Stern
2012-03-29 5:45 ` Lin Ming
2012-03-29 13:50 ` Aaron Lu
2012-03-29 15:00 ` Alan Stern
2012-03-30 1:07 ` Aaron Lu
2012-03-30 14:28 ` Alan Stern
2012-03-31 10:45 ` Jan Ceuleers
2012-04-01 10:34 ` Aaron Lu
2012-04-05 6:00 ` Lin Ming
2012-04-05 8:32 ` Aaron Lu
2012-04-05 8:48 ` Lin Ming
2012-04-05 14:03 ` Alan Stern
2012-04-06 6:13 ` Lin Ming
2012-04-06 6:10 ` Lin Ming
2012-04-06 16:01 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F72F45D.7090800@mvista.com \
--to=sshtylyov@mvista.com \
--cc=aaron.lu@amd.com \
--cc=jgarzik@pobox.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).